You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/18 13:32:00 UTC
[jira] [Work logged] (KNOX-2161) Allow descriptors to be read-only
on Admin UI
[ https://issues.apache.org/jira/browse/KNOX-2161?focusedWorklogId=388804&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388804 ]
ASF GitHub Bot logged work on KNOX-2161:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/20 13:31
Start Date: 18/Feb/20 13:31
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #265: KNOX-2161 - CM generated descriptors are read-only on Admin UI
URL: https://github.com/apache/knox/pull/265
## What changes were proposed in this pull request?
#236 introduces a new descriptor type (using on Hadoop XML structure). Descriptors generated out of those XML configurations are read-only on Admin UI from now on.
## How was this patch tested?
Updated and executed JUnit tests.
Additionally, the following manual test steps were executed:
1. built and deployed Knox with my changes
2. logged into Admin UI
3. created a descriptor called `testDescriptor` on Admin UI
4. placed the following CM-type descriptor in Knox's descriptor directory:
```
<configuration>
<property>
<name>topology1</name>
<value>
providerConfigRef=default-providers;
app:knoxauth:param1.name=param1.value;
HIVE:url=http://localhost:456;
HIVE:version=1.0;
HIVE:httpclient.connectionTimeout=5m;
HIVE:httpclient.socketTimeout=100m
</value>
</property>
<property>
<name>topology2</name>
<value>
providerConfigRef=default-providers;
HDFS:url=http://localhost:456;
HDFS:httpclient.connectionTimeout=5m;
HDFS:httpclient.socketTimeout=100m
</value>
</property>
</configuration>
```
5. confirmed that:
`testDescriptor` is not read-only; it can be updated/removed
`topology1` and `topology2` descriptors are read-only: they cannot be removed/updted (no icons displayed)
<img width="1666" alt="Screen Shot 2020-02-18 at 2 25 29 PM" src="https://user-images.githubusercontent.com/34065904/74740505-49178080-525b-11ea-9bd8-becb55624d37.png">
<img width="1668" alt="Screen Shot 2020-02-18 at 2 25 45 PM" src="https://user-images.githubusercontent.com/34065904/74740511-4c127100-525b-11ea-93aa-505761ec16c8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 388804)
Remaining Estimate: 0h
Time Spent: 10m
> Allow descriptors to be read-only on Admin UI
> ---------------------------------------------
>
> Key: KNOX-2161
> URL: https://issues.apache.org/jira/browse/KNOX-2161
> Project: Apache Knox
> Issue Type: New Feature
> Components: AdminUI
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> KNOX-2160 introduces a new descriptor type (using on Hadoop XML structure). Descriptors generated out of those XML configurations should be read-only on Admin UI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)