[jira] Commented: (TAP5-891) RequestImpl.getSession(true) is broken

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983009#action_12983009 ] 

Hudson commented on TAP5-891:
-----------------------------

Integrated in tapestry-5.2-freestyle #252 (See [https://hudson.apache.org/hudson/job/tapestry-5.2-freestyle/252/])
    

> RequestImpl.getSession(true) is broken
> --------------------------------------
>
>                 Key: TAP5-891
>                 URL: https://issues.apache.org/jira/browse/TAP5-891
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Olle Hallin
>         Attachments: RequestImpl.java, RequestImplTest.java
>
>
> I think that the implementation of org.apache.tapestry5.internal.services.RequestImpl.getSession(true) is broken.
> It returns an old invalidated session instead of creating a new.
> IMO this is a bug since it behaves differently than HttpServletRequest.getSession(true).
> This is the expected behaviour:
> 1. Session s1 = request.getSession(true);
> 2. s1.invalidate();
> 3. Session s2 = request.getSession(true);
> 4. assertNotNull(s2);
> 5. assertNotSame(s1, s2);
> 6. assertFalse(s2.isInvalidated());

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.