You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/08 13:34:42 UTC

[GitHub] [druid] kfaraz opened a new pull request #11889: Ensure backward compatibility of multi dimension partitioning

kfaraz opened a new pull request #11889:
URL: https://github.com/apache/druid/pull/11889


   ### Description
   This PR has changes to ensure backward compatibility of multi dimension partitioning
   such that if some middle managers are upgraded to a newer version, the cluster still
   functions normally for single_dim use cases.
   
   ### Changes
   - Make `BuildingSingleDimensionShardSpec` extend `BuildingDimensionRangeShardSpec`
   - Convert `DimensionRangeBucketShardSpec` to `BuildingSingleDim` or `BuildingDimRange`
      as applicable
   - Serialize/deserialize `PartitionBoundaries` as an array of Strings instead of an array of `StringTuples`
      for single dimension use cases (i.e. when each boundary is either null or is a tuple of size 1)
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [ ] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz commented on pull request #11889: Ensure backward compatibility of multi dimension partitioning

Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11889:
URL: https://github.com/apache/druid/pull/11889#issuecomment-963847196


   > Generally looks good to me. If there's one comment, given that this is a backwards compat change, I think there could be value in some tests that prove JSON deserialization "works" by starting with a map and using an ObjectMapper to convert that to the object that we expect.
   
   Thanks for the review, @cheddar.
   I can add a test that serializes the return value of the method `getSerializableObject()` and then deserializes it back to get the original object. Would that suffice?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] abhishekagarwal87 merged pull request #11889: Ensure backward compatibility of multi dimension partitioning

Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged pull request #11889:
URL: https://github.com/apache/druid/pull/11889


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz edited a comment on pull request #11889: Ensure backward compatibility of multi dimension partitioning

Posted by GitBox <gi...@apache.org>.
kfaraz edited a comment on pull request #11889:
URL: https://github.com/apache/druid/pull/11889#issuecomment-963847196


   > Generally looks good to me. If there's one comment, given that this is a backwards compat change, I think there could be value in some tests that prove JSON deserialization "works" by starting with a map and using an ObjectMapper to convert that to the object that we expect.
   
   Thanks for the review, @cheddar.
   I can add a test that serializes the return value of the method `getSerializableObject()` and then deserializes it back to get the original object. Would that suffice?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] kfaraz edited a comment on pull request #11889: Ensure backward compatibility of multi dimension partitioning

Posted by GitBox <gi...@apache.org>.
kfaraz edited a comment on pull request #11889:
URL: https://github.com/apache/druid/pull/11889#issuecomment-963847196


   > Generally looks good to me. If there's one comment, given that this is a backwards compat change, I think there could be value in some tests that prove JSON deserialization "works" by starting with a map and using an ObjectMapper to convert that to the object that we expect.
   
   Thanks for the review, @cheddar.
   I can add a test that serializes the return value of the method `getSerializableObject()` and then deserialize it back to get the original object. Would that suffice?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org