You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ra...@apache.org on 2025/06/16 07:30:23 UTC
(arrow-skyhook) 13/18: GH-39823: [C++] Allow building cpp/src/arrow/**/*.cc without waiting bundled libraries (#39824)
This is an automated email from the ASF dual-hosted git repository.
raulcd pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-skyhook.git
commit f72fc468569d3dd3d2066ec884c7fc759ad86699
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Thu Feb 29 09:44:15 2024 +0900
GH-39823: [C++] Allow building cpp/src/arrow/**/*.cc without waiting bundled libraries (#39824)
### Rationale for this change
If we can build most of `cpp/src/arrow/**/*.cc` before all bundled libraries are built, we can reduce build time.
### What changes are included in this PR?
* Remove the `toolchain` internal CMake target
* Remove `ARROW_SHARED_LINK_LIBS`
* Remove `ARROW_STATIC_LINK_LIBS`
* Move the following variables to `cpp/src/arrow/CMakeLists.txt`
* `ARROW_SHARED_PRIVATE_LINK_LIBS`
* `ARROW_SHARED_INSTALL_INTERFACE_LIBS`
* `ARROW_STATIC_INSTALL_INTERFACE_LIBS`
* `ARROW_TEST_LINK_TOOLCHAIN`
* `ARROW_TEST_SHARED_LINK_LIBS`
* `ARROW_TEST_STATIC_LINK_LIBS`
* `ARROW_SYSTEM_LINK_LIBS`
* Add internal `OBJECT` libraries that have minimal dependencies
* Remove unused `cpp/src/arrow/util/benchmark_main.cc`
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes: #39823
* GitHub Issue: #39823
Authored-by: Sutou Kouhei <ko...@clear-code.com>
Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
CMakeLists.txt | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 67fddec..1b41e34 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -43,8 +43,11 @@ add_arrow_lib(arrow_skyhook
ARROW_SKYHOOK_CLIENT_LIBRARIES
SHARED_LINK_LIBS
${ARROW_SKYHOOK_LINK_SHARED}
+ SHARED_PRIVATE_LINK_LIBS
+ arrow::flatbuffers
STATIC_LINK_LIBS
- ${ARROW_SKYHOOK_LINK_STATIC})
+ ${ARROW_SKYHOOK_LINK_STATIC}
+ arrow::flatbuffers)
# define the cls library
add_arrow_lib(cls_skyhook
@@ -54,6 +57,8 @@ add_arrow_lib(cls_skyhook
ARROW_SKYHOOK_CLS_LIBRARIES
SHARED_LINK_LIBS
${ARROW_SKYHOOK_LINK_SHARED}
+ SHARED_PRIVATE_LINK_LIBS
+ arrow::flatbuffers
STATIC_LINK_LIBS
${ARROW_SKYHOOK_LINK_STATIC})