You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2026/10/18 21:09:50 UTC
(maven-mvnd) 01/05: Honour an explicit false value of void options
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-mvnd.git
commit 555aac91625ecd0e781bc9bdf46d9aab5753bfd8
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Sun Oct 18 20:31:16 2026 +0200
Honour an explicit false value of void options
Fixes #720
---
.../java/org/mvndaemon/mvnd/client/EnvironmentTest.java | 12 ++++++++++++
.../main/java/org/mvndaemon/mvnd/common/Environment.java | 15 ++++++++++-----
2 files changed, 22 insertions(+), 5 deletions(-)
diff --git a/client/src/test/java/org/mvndaemon/mvnd/client/EnvironmentTest.java b/client/src/test/java/org/mvndaemon/mvnd/client/EnvironmentTest.java
index 660d93c4..5394b34c 100644
--- a/client/src/test/java/org/mvndaemon/mvnd/client/EnvironmentTest.java
+++ b/client/src/test/java/org/mvndaemon/mvnd/client/EnvironmentTest.java
@@ -73,6 +73,18 @@ public class EnvironmentTest {
}
}
+ @Test
+ void voidOptionHonoursExplicitFalse() {
+ Assertions.assertNull(Environment.SERIAL.getCommandLineOption(list("-Dmvnd.serial=false")));
+ Assertions.assertNull(Environment.SERIAL.getCommandLineOption(list("--serial=false")));
+ assertEquals("", Environment.SERIAL.getCommandLineOption(list("-Dmvnd.serial=true")));
+ assertEquals("", Environment.SERIAL.getCommandLineOption(list("--serial")));
+ assertEquals("", Environment.SERIAL.getCommandLineOption(list("-1")));
+ List<String> args = list("-Dmvnd.serial=false", "clean");
+ Assertions.assertNull(Environment.SERIAL.removeCommandLineOption(args));
+ assertEquals(list("clean"), args);
+ }
+
private List<String> list(String... items) {
return new ArrayList<>(Arrays.asList(items));
}
diff --git a/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java b/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java
index d53c7597..9ed9194d 100644
--- a/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java
+++ b/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java
@@ -506,13 +506,18 @@ public enum Environment {
if (remove) {
it.remove();
}
+ String opt = Stream.of(prefixes)
+ .filter(prefix -> matchesCommandLineOption(arg, prefix))
+ .max(Comparator.comparing(String::length))
+ .get();
if (type == OptionType.VOID) {
- value = "";
+ String explicit = arg.substring(opt.length());
+ if (explicit.startsWith("=")) {
+ explicit = explicit.substring(1);
+ }
+ // an explicit "false" switches the option off
+ value = "false".equalsIgnoreCase(explicit) ? null : "";
} else {
- String opt = Stream.of(prefixes)
- .filter(prefix -> matchesCommandLineOption(arg, prefix))
- .max(Comparator.comparing(String::length))
- .get();
value = arg.substring(opt.length());
if (value.isEmpty()) {
if (it.hasNext()) {