You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/29 03:11:22 UTC

[GitHub] [incubator-nuttx] btashton opened a new pull request #2154: build: Fix testbuild.sh artifact copy on macOS

btashton opened a new pull request #2154:
URL: https://github.com/apache/incubator-nuttx/pull/2154


   ## Summary
   xargs for macOS does not support the '-a/--file-arg' flag so build artifacts were not getting stored.  This change passes it in via stdin which is more portable.
   
   ## Impact
   Build artifacts are preserved when ./tools/testbuild.sh is used with the `-A` flag on macOS.
   
   ## Testing
   Local Linux testing and macOS for CI.  We should see both linux-build and macos-build artiact bundles created by the CI system.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2154: build: Fix testbuild.sh artifact copy on macOS

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2154:
URL: https://github.com/apache/incubator-nuttx/pull/2154


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #2154: build: Fix testbuild.sh artifact copy on macOS

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2154:
URL: https://github.com/apache/incubator-nuttx/pull/2154#issuecomment-718364356


   Looks like macOS also does not support the `-t` operator for `cp`
   
   ```
     Building NuttX...
   cp: illegal option -- t
   usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file target_file
          cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file ... target_directory
   ```
   
   Switched to using the placeholder method which should be supported:
   ```
   xargs -I "{}" cp "{}" $artifactconfigdir < $nuttx/nuttx.manifest
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2154: build: Fix testbuild.sh artifact copy on macOS

Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2154:
URL: https://github.com/apache/incubator-nuttx/pull/2154#issuecomment-718364356


   Looks like macOS also does not support the `-t` argument for `cp`
   
   ```
     Building NuttX...
   cp: illegal option -- t
   usage: cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file target_file
          cp [-R [-H | -L | -P]] [-fi | -n] [-apvXc] source_file ... target_directory
   ```
   
   Switched to using the placeholder method which should be supported:
   ```
   xargs -I "{}" cp "{}" $artifactconfigdir < $nuttx/nuttx.manifest
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org