You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/30 07:32:10 UTC
[GitHub] [incubator-superset] villebro edited a comment on issue #7131: Make
timestamp expression native SQLAlchemy element
villebro edited a comment on issue #7131: Make timestamp expression native SQLAlchemy element
URL: https://github.com/apache/incubator-superset/pull/7131#issuecomment-478216651
Rebased to fix conflict. @agrawaldevesh thanks for offering to help verify this PR! Regarding the timezone issue, I think it's something that runs slightly deeper in the code, so would probably require some additional planning (perhaps a SIP). Perhaps something along the lines of a setting in `superset_config.py` to specify a timezone in which all timestamps with timezone info would be cast to (naive timestamps would probably be kept unchanged)? Anyway, a really good idea worth investigating (committer guidance would be helpful).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org