You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2025/07/07 20:01:06 UTC

[PR] Ci cache [datafusion]

blaginin opened a new pull request, #16709:
URL: https://github.com/apache/datafusion/pull/16709

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   - Closes #.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on code in PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#discussion_r2202511856


##########
.github/actions/setup-macos-aarch64-builder/action.yaml:
##########
@@ -45,5 +45,7 @@ runs:
         rustup component add rustfmt
     - name: Setup rust cache
       uses: Swatinem/rust-cache@v2
+      with:
+           save-if: ${{ github.ref_name == 'main' }}

Review Comment:
   So should be good as is!
   
   This line is added because we now cache CI runs on any branch, which takes up all our free CI space 😱 (which also made it hard to test during development)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#issuecomment-3065073253

   Well, let's merge it and see how it works in action and iterate !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#issuecomment-3065139181

   
   before
   https://github.com/apache/datafusion/actions/runs/16237392836/attempts/1
   
   after
   https://github.com/apache/datafusion/actions/runs/16237392836
   
   
   seems to be working!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#issuecomment-3065058878

   https://github.com/apache/datafusion/actions/runs/16207285209/job/45760367631?pr=16709
   Seems to still be 5 minutes:
   <img width="264" height="207" alt="Screenshot 2025-07-12 at 6 43 00 AM" src="https://github.com/user-attachments/assets/478cef15-5e66-4965-97e6-d7bbd4c4a23f" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#issuecomment-3065061371

   > I did look at the timings for the CI jobs on this PR and on main and they didn't seem all that different. However since most of this caching is happening on main I suspect we'll see the benefits after we merge this
   
   Yes, exactly. When doing the development, I removed "save-if" condition: https://github.com/apache/datafusion/actions/runs/16128523988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#issuecomment-3065147959

   13% faster -- not bad!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#discussion_r2202500711


##########
.github/actions/setup-macos-aarch64-builder/action.yaml:
##########
@@ -45,5 +45,7 @@ runs:
         rustup component add rustfmt
     - name: Setup rust cache
       uses: Swatinem/rust-cache@v2

Review Comment:
   TIL that `rust-cache` caches the Rust binaries too
   
   https://github.com/Swatinem/rust-cache?tab=readme-ov-file#cache-details



##########
.github/actions/setup-macos-aarch64-builder/action.yaml:
##########
@@ -45,5 +45,7 @@ runs:
         rustup component add rustfmt
     - name: Setup rust cache
       uses: Swatinem/rust-cache@v2

Review Comment:
   Also, something I noticed was maybe we should pin to an actual hash rather than a tag that is updated
   
   https://github.com/Swatinem/rust-cache/tags
   
   I think security best practice would be to pin to https://github.com/Swatinem/rust-cache/commit/98c8021b550208e191a6a3145459bfc9fb29c4c0 for example rather than https://github.com/Swatinem/rust-cache/releases/tag/v2
   
   However, this wasn't introduced in this PR so I don't think it needs to be fixed here 
   
   



##########
.github/actions/setup-macos-aarch64-builder/action.yaml:
##########
@@ -45,5 +45,7 @@ runs:
         rustup component add rustfmt
     - name: Setup rust cache
       uses: Swatinem/rust-cache@v2
+      with:
+           save-if: ${{ github.ref_name == 'main' }}

Review Comment:
   Should this also have the `shared-key: amd` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on code in PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#discussion_r2202511007


##########
.github/actions/setup-macos-aarch64-builder/action.yaml:
##########
@@ -45,5 +45,7 @@ runs:
         rustup component add rustfmt
     - name: Setup rust cache
       uses: Swatinem/rust-cache@v2
+      with:
+           save-if: ${{ github.ref_name == 'main' }}

Review Comment:
   This is a macos run, so I don't this we should use shared key with other runs (which are on linux) 
   
   If shared key isn't set, job-based one is used: https://github.com/Swatinem/rust-cache/blob/7e1e2d0a10862b34e5df481373b2b0f295d1a2ef/action.yml#L10



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Improve Ci cache [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #16709:
URL: https://github.com/apache/datafusion/pull/16709


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Ci cache [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #16709:
URL: https://github.com/apache/datafusion/pull/16709#issuecomment-3059328323

   linux build test: 5m → 2m
   check substrait features: 11m → 9m
   cargo test (amd64): 18m → 16m
   cargo examples: 17m → 11m
   clippy: 6m → 5m
   
   really like linux build test improvement, as it's a bottleneck for the other tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org