You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/20 21:44:40 UTC

[GitHub] [airflow] uranusjr commented on pull request #21688: Simplify check_cycle() implement

uranusjr commented on pull request #21688:
URL: https://github.com/apache/airflow/pull/21688#issuecomment-1046326977


   If the two functions are indeed equivalent, perhaps we should deprecate `check_cycle` altogether. Also if we are to replace `check_cycle` with `topological_sort` (whether to deprecate the former or not), the latter needs to be modified to raise `AirflowDagCycleException` instead, for backward compatibility. (Fortunately it currently raise `AirflowException`, which is the superclass of `AirflowDagCycleException`, so changing the exception type would be backward compatible.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org