[GitHub] [incubator-seatunnel] Xuxiaotuan commented on a diff in pull request #2830: [Feature][Connector-V2][TiKV] Support TiKV Source & Sink

[GitBox <gi...@apache.org>]

Xuxiaotuan commented on code in PR #2830:
URL: https://github.com/apache/incubator-seatunnel/pull/2830#discussion_r996584755


##########
seatunnel-connectors-v2/connector-tikv/src/main/java/org/apache/seatunnel/connectors/seatunnel/tikv/source/TiKVSource.java:
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.tikv.source;
+
+import org.apache.seatunnel.api.common.PrepareFailException;
+import org.apache.seatunnel.api.serialization.DeserializationSchema;
+import org.apache.seatunnel.api.serialization.Serializer;
+import org.apache.seatunnel.api.source.Boundedness;
+import org.apache.seatunnel.api.source.SeaTunnelSource;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.common.config.CheckConfigUtil;
+import org.apache.seatunnel.common.config.CheckResult;
+import org.apache.seatunnel.common.constants.PluginType;
+import org.apache.seatunnel.connectors.seatunnel.common.schema.SeaTunnelSchema;
+import org.apache.seatunnel.connectors.seatunnel.common.source.AbstractSingleSplitReader;
+import org.apache.seatunnel.connectors.seatunnel.common.source.AbstractSingleSplitSource;
+import org.apache.seatunnel.connectors.seatunnel.common.source.SingleSplitEnumeratorState;
+import org.apache.seatunnel.connectors.seatunnel.common.source.SingleSplitReaderContext;
+import org.apache.seatunnel.connectors.seatunnel.tikv.config.TiKVConfig;
+import org.apache.seatunnel.connectors.seatunnel.tikv.config.TiKVParameters;
+import org.apache.seatunnel.format.json.JsonDeserializationSchema;
+
+import org.apache.seatunnel.shade.com.typesafe.config.Config;
+
+import com.google.auto.service.AutoService;
+
+@AutoService(SeaTunnelSource.class)
+public class TiKVSource extends AbstractSingleSplitSource<SeaTunnelRow> {
+
+    private final TiKVParameters tikvParameters = new TiKVParameters();
+
+    private SeaTunnelRowType seaTunnelRowType;
+
+    private DeserializationSchema<SeaTunnelRow> deserializationSchema;
+
+    @Override
+    public String getPluginName() {
+        return TiKVConfig.NAME;
+    }
+
+    /**
+     * init configuration parameters
+     *
+     * @param config plugin config.
+     * @throws PrepareFailException prepare failed
+     */
+    @Override
+    public void prepare(Config config) throws PrepareFailException {
+        CheckResult result = CheckConfigUtil.checkAllExists(config, TiKVConfig.HOST, TiKVConfig.DATA_TYPE, TiKVConfig.DATA_TYPE);
+        if (!result.isSuccess()) {
+            throw new PrepareFailException(getPluginName(), PluginType.SOURCE, result.getMsg());
+        }
+        // init tikv configuration
+        this.tikvParameters.initConfig(config);
+
+        // init seaTunnelRowType
+        if (config.hasPath(SeaTunnelSchema.SCHEMA)) {
+            Config schema = config.getConfig(SeaTunnelSchema.SCHEMA);
+            this.seaTunnelRowType = SeaTunnelSchema.buildWithConfig(schema).getSeaTunnelRowType();
+        } else {
+            this.seaTunnelRowType = SeaTunnelSchema.buildSimpleTextSchema();
+        }
+
+        if (config.hasPath(TiKVConfig.FORMAT)) {
+            this.deserializationSchema = null;
+        } else {
+            this.deserializationSchema = new JsonDeserializationSchema(false, false, seaTunnelRowType);
+        }
+    }
+
+    @Override
+    public Boundedness getBoundedness() {
+        return Boundedness.BOUNDED;
+    }
+
+    @Override
+    public SeaTunnelDataType<SeaTunnelRow> getProducedType() {
+        return seaTunnelRowType;
+    }
+
+    @Override
+    public AbstractSingleSplitReader<SeaTunnelRow> createReader(SingleSplitReaderContext readerContext) throws Exception {
+        return new TiKVSourceReader(tikvParameters, readerContext, deserializationSchema);
+    }
+
+    @Override
+    public Serializer<SingleSplitEnumeratorState> getEnumeratorStateSerializer() {

Review Comment:
   > remove this method
   
   ok，I'm going to modify it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org