[GitHub] [incubator-superset] willbarrett opened a new pull request #8493: Fix column type on dbs.encrypted_extra, add instructions for testing migration downgrades

[GitBox <gi...@apache.org>]

willbarrett opened a new pull request #8493: Fix column type on dbs.encrypted_extra, add instructions for testing migration downgrades
URL: https://github.com/apache/incubator-superset/pull/8493
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   The new `encrypted_extra` field on the `dbs` table was causing the databases list to become inaccessible when used with Postgres. This was caused by a type misalignment between the database and the model definition. Also add instructions in CONTRIBUTING.md around testing down migrations.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - [ ] Set up a BigQuery connection according to instructions here: https://github.com/apache/incubator-superset/pull/8462
   - [ ] Ensure the databases/list page is still accessible
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [X] Requires DB Migration.
   - [X] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @dpgaspar @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org