You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/01/18 09:24:20 UTC

[GitHub] [calcite] hannerwang opened a new pull request #2328: [CALCITE-4471] "SqlBetweenOperator" should support writing optional "ASYMMETRIC" or "SYMMETRIC" flag

hannerwang opened a new pull request #2328:
URL: https://github.com/apache/calcite/pull/2328


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] hannerwang closed pull request #2328: [CALCITE-4471] "SqlBetweenOperator" should support writing optional "ASYMMETRIC" or "SYMMETRIC" flag

Posted by GitBox <gi...@apache.org>.
hannerwang closed pull request #2328:
URL: https://github.com/apache/calcite/pull/2328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] hannerwang closed pull request #2328: [CALCITE-4471] "SqlBetweenOperator" should support writing optional "ASYMMETRIC" or "SYMMETRIC" flag

Posted by GitBox <gi...@apache.org>.
hannerwang closed pull request #2328:
URL: https://github.com/apache/calcite/pull/2328


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] amaliujia commented on pull request #2328: [CALCITE-4471] "SqlBetweenOperator" should support writing optional "ASYMMETRIC" or "SYMMETRIC" flag

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #2328:
URL: https://github.com/apache/calcite/pull/2328#issuecomment-762525950


   @hannerwang 
   
   Can you rebase this PR firstly to solve the conflict? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [calcite] amaliujia commented on a change in pull request #2328: [CALCITE-4471] "SqlBetweenOperator" should support writing optional "ASYMMETRIC" or "SYMMETRIC" flag

Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #2328:
URL: https://github.com/apache/calcite/pull/2328#discussion_r559926002



##########
File path: core/src/test/java/org/apache/calcite/sql/parser/SqlParserTest.java
##########
@@ -1195,6 +1196,95 @@ protected boolean isReserved(String word) {
         .ok("VALUES (ROW((`A` BETWEEN ASYMMETRIC ((`B` OR (`C` AND `D`)) OR `E`) AND `F`)))");
   }
 
+  @Test void testBetweenSpark() {

Review comment:
       Can you test these in `RelToSqlConverterTest`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org