You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/11/12 08:59:16 UTC

[GitHub] [incubator-echarts] IamKennethBurla opened a new issue #13609: Tree chart rerenders as I add new children to each node data

IamKennethBurla opened a new issue #13609:
URL: https://github.com/apache/incubator-echarts/issues/13609


   ### Version
   4.9.0
   
   ### Issue
   Currently what I'm doing is updating the data I'm supplying to echarts component (ReactEcharts). 
   As expect it would re-renders everything when I update the data (`series.data`). What I would like to happened is just update the data and append the node children to chart, without re-rendering the actual chart instance
   
   Is it possible or is there already a workaround to achieve such output?.
   
   ### Sample scenario
   
   ![rerender issue](https://user-images.githubusercontent.com/36767756/98917980-05ab2380-2508-11eb-9fc8-27de7dcb5dd0.gif)
   
   ### What is expected?
   Attach an additional node children without re-rendering tree chart instance
   
   ### What is actually happening?
   Re-renders tree chart instance when I update `series.data` of tree chart
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] pissang commented on issue #13609: Tree chart rerenders as I add new children to each node data

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #13609:
URL: https://github.com/apache/incubator-echarts/issues/13609#issuecomment-727765712


   I'm not familiar with React. But I guess it's probably because each time the chart is recreated. Also, you need to set {notMerge} to false


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] IamKennethBurla commented on issue #13609: Tree chart rerenders as I add new children to each node data

Posted by GitBox <gi...@apache.org>.
IamKennethBurla commented on issue #13609:
URL: https://github.com/apache/incubator-echarts/issues/13609#issuecomment-732390116


   But is it possible not to rerender the chart on outside react? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] IamKennethBurla edited a comment on issue #13609: Tree chart rerenders as I add new children to each node data

Posted by GitBox <gi...@apache.org>.
IamKennethBurla edited a comment on issue #13609:
URL: https://github.com/apache/incubator-echarts/issues/13609#issuecomment-727537685


   > @IamKennethBurla Please provide a demo for the issue either with https://codepen.io/Ovilia/pen/dyYWXWM or https://gallery.echartsjs.com/editor.html.
   
   Here is a demo of the scenario .https://codesandbox.io/s/node-tree-0imgc
   When you click the node2 it'll re-render the entire chart.
   Looking for a way to just append the data to current instance without re-rendering the entire chart
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13609: Tree chart rerenders as I add new children to each node data

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #13609:
URL: https://github.com/apache/incubator-echarts/issues/13609#issuecomment-726584388


   @IamKennethBurla Please provide a demo for the issue either with https://codepen.io/Ovilia/pen/dyYWXWM or https://gallery.echartsjs.com/editor.html.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [incubator-echarts] IamKennethBurla commented on issue #13609: Tree chart rerenders as I add new children to each node data

Posted by GitBox <gi...@apache.org>.
IamKennethBurla commented on issue #13609:
URL: https://github.com/apache/incubator-echarts/issues/13609#issuecomment-727537685


   > @IamKennethBurla Please provide a demo for the issue either with https://codepen.io/Ovilia/pen/dyYWXWM or https://gallery.echartsjs.com/editor.html.
   
   Here is a demo of the scenario. https://codesandbox.io/s/crypto-node-tree-0imgc?file=/src/Chart.js
   When you click the node2 it'll re-render the entire chart.
   Looking for a way to just append the data to current instance without re-rendering the entire chart
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org