You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/29 04:42:00 UTC

[GitHub] [airflow] akki commented on a change in pull request #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)

akki commented on a change in pull request #5489: [AIRFLOW-4843] Allow orchestration via Docker Swarm (SwarmOperator)
URL: https://github.com/apache/airflow/pull/5489#discussion_r298787544
 
 

 ##########
 File path: airflow/operators/swarm_operator.py
 ##########
 @@ -0,0 +1,174 @@
+# -*- coding: utf-8 -*-
 
 Review comment:
   @mik-laj I didn't know that, thanks for pointing out - I'll get to it.
   
   Also, can you please tell me what [Travis Pylint](https://travis-ci.org/apache/airflow/jobs/550935644) expects when it says `Too many instance attributes (18/15) (too-many-instance-attributes)` and `Specify string format arguments as logging function parameters`?
   I see other operator classes with much more attributes than **15** and logging strings the way I am doing in this PR - `self.log.info('Service started: %s' % str(self.service))`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services