You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/16 16:47:33 UTC

[GitHub] [spark] huaxingao opened a new pull request #26142: [SPARK-29381][FOLLOWUP][PYTHON][ML] Add 'private' _XXXParams classes for classification & regression

huaxingao opened a new pull request #26142: [SPARK-29381][FOLLOWUP][PYTHON][ML] Add 'private' _XXXParams classes for classification & regression
URL: https://github.com/apache/spark/pull/26142
 
 
   ### What changes were proposed in this pull request?
   Add private _XXXParams classes for classification & regression
   
   
   ### Why are the changes needed?
   To keep parity between scala and python
   
   
   ### Does this PR introduce any user-facing change?
   Yes. Add gettters/setters for the following Model classes
   
   ```
   LinearSVCModel:
   get/setRegParam
   get/setMaxIte
   get/setFitIntercept
   get/setTol
   get/setStandardization
   get/setWeightCol
   get/setAggregationDepth
   get/setThreshold
   
   LogisticRegressionModel:
   get/setRegParam
   get/setElasticNetParam
   get/setMaxIter
   get/setFitIntercept
   get/setTol
   get/setStandardization
   get/setWeightCol
   get/setAggregationDepth
   get/setThreshold
   
   NaiveBayesModel:
   get/setWeightCol
   
   LinearRegressionModel:
   get/setRegParam
   get/setElasticNetParam
   get/setMaxIter
   get/setTol
   get/setFitIntercept
   get/setStandardization
   get/setWeight
   get/setSolver
   get/setAggregationDepth
   get/setLoss
   
   GeneralizedLinearRegressionModel:
   get/setFitIntercept
   get/setMaxIter
   get/setTol
   get/setRegParam
   get/setWeightCol
   get/setSolver
   ```
   
   ### How was this patch tested?
   Add a few doctest
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org