You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/01 15:55:30 UTC

[GitHub] [iceberg] tprelle opened a new pull request #2657: Docs : Add snapshot incremental read on spark doc

tprelle opened a new pull request #2657:
URL: https://github.com/apache/iceberg/pull/2657


   Since https://github.com/apache/iceberg/pull/829 and https://github.com/apache/iceberg/pull/1782 spark support incremental read but I do not found it inside documentation. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] tprelle commented on pull request #2657: Docs : Add snapshot incremental read on spark doc

Posted by GitBox <gi...@apache.org>.
tprelle commented on pull request #2657:
URL: https://github.com/apache/iceberg/pull/2657#issuecomment-853240341


   @coolderli thanks for the feed back. I was testing in spark 2. And i check it's only tested for spark2 So I add that it's currently supported only for Spark 2. I will check why it's not working in spark 3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #2657: Docs : Add snapshot incremental read on spark doc

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2657:
URL: https://github.com/apache/iceberg/pull/2657#issuecomment-861042571


   @tprelle, the `spark.md` file has been split across several other files in the docs site. We've left it as-is so that existing links continue to function and so that we can move links internal to the site over to the new pages. But the actual documentation should probably be in [`spark-queries.md` instead](https://iceberg.apache.org/spark-queries/).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] tprelle commented on pull request #2657: Docs : Add snapshot incremental read on spark doc

Posted by GitBox <gi...@apache.org>.
tprelle commented on pull request #2657:
URL: https://github.com/apache/iceberg/pull/2657#issuecomment-853285268


   @coolderli only append it's currently supported by the code : https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/IncrementalDataTableScan.java#L123
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] coolderli commented on pull request #2657: Docs : Add snapshot incremental read on spark doc

Posted by GitBox <gi...@apache.org>.
coolderli commented on pull request #2657:
URL: https://github.com/apache/iceberg/pull/2657#issuecomment-852658071


   I have tested the incremental read with spark, it doesn't support the v2 table.  If the operation of the start snapshot is not the `append`, it doesn't work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org