You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Cornelia Burko (JIRA)" <ji...@apache.org> on 2008/03/13 08:53:49 UTC
[jira] Created: (JSPWIKI-208) Hide RSS images if deactivated
Hide RSS images if deactivated
------------------------------
Key: JSPWIKI-208
URL: https://issues.apache.org/jira/browse/JSPWIKI-208
Project: JSPWiki
Issue Type: Improvement
Components: Default template
Affects Versions: 2.6.0
Reporter: Cornelia Burko
Priority: Minor
If the RSS feed is disabled in the jwpwiki.properties the image is still shown beneath each article.
This one is not even marked by an specified css-class or id, so it could not easily hidden via css.
The RSS image next to the jspwiki - version is hidden. It would be great if the other images are hidden too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (JSPWIKI-208) Hide RSS images if deactivated
Posted by Dirk Frederickx <di...@gmail.com>.
Well, this issue is not the icon ...
Actually the tag should probably be extended with a page parameter,
cause the current tag only issues a rss url for the whole wiki, and
not a feed of a particular page.
dirk
On Wed, May 14, 2008 at 9:29 PM, Janne Jalkanen
<Ja...@ecyrd.com> wrote:
>
> On May 14, 2008, at 22:15 , Dirk Frederickx wrote:
>
>> Janne,
>>
>>
>> This allows skins to change the image.
>>
>> This has been a generic approach throughout the new template. (logo's,
>> other images, only the attachment icons still need to be handled)
>> Ensure presentation stuff is moved to css, so it can be changed
>> according the skins.
>>
>> In the below code snippit, the should actually be changed by a
>> line-of-text, eg "RSS-feed", so things are still accessible when icons
>> are not loaded.
>
> But it causes a massive cases of duplicate code all around! We've got the
> perfectly good RSSImageLink tag, so we should use it instead. Note that now
> we are using both, so a skin cannot really change the icon at all.
>
> Also, I am not sure whether that increases accessibility (I know, it's
> already pretty bad), but having a as link text is probably not what
> we really want.
>
> I think it should be much better to move all this code into RSSImageLinkTag.
>
> /Janne
>
Re: [jira] Commented: (JSPWIKI-208) Hide RSS images if deactivated
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
On May 14, 2008, at 22:15 , Dirk Frederickx wrote:
> Janne,
>
>
> This allows skins to change the image.
>
> This has been a generic approach throughout the new template. (logo's,
> other images, only the attachment icons still need to be handled)
> Ensure presentation stuff is moved to css, so it can be changed
> according the skins.
>
> In the below code snippit, the should actually be changed by a
> line-of-text, eg "RSS-feed", so things are still accessible when icons
> are not loaded.
But it causes a massive cases of duplicate code all around! We've
got the perfectly good RSSImageLink tag, so we should use it
instead. Note that now we are using both, so a skin cannot really
change the icon at all.
Also, I am not sure whether that increases accessibility (I know,
it's already pretty bad), but having a as link text is
probably not what we really want.
I think it should be much better to move all this code into
RSSImageLinkTag.
/Janne
Re: [jira] Commented: (JSPWIKI-208) Hide RSS images if deactivated
Posted by Dirk Frederickx <di...@gmail.com>.
Murray,
a) There is no javascript involved here, it is pure html and css.
Turn of js, and you'll see what I mean.
b) IMHO Accesibility is ok cause the body of the link actually shows a
text, you can add a title attribute as well.
The example given by Janne doesn't have a proper text yet, but that
should be changed. Check out the logo for the example.
c) If you don't want to change the image in a skin that's fine, you do
not need to.
The current approach allows you to write only a skin and not change
the template, and still be capable of changing most of presentational
matters of the template.
I do agree with the point of Janne, that this stuff should be
preferably be covered inside the <wiki:.../> tags iso explicitly in
the jsp's. At least it will increase readabilty and reusability.
dirk
>
> The downside of this is twofold.
>
> a. if JavaScript if off, the images aren't seen. This is not simply
> an aesthetic issue -- it may also affect branding and is considered
> by many site managers a Pretty Big Deal.
> b. absent the <img> elements there is no 'alt' text, so accessibility
> suffers. E.g., I just realized that we have a *requirement* (set
> by the government) to provide accessible websites, and that includes
> alt text on *all* images. (yuck) We can probably skirt by on the
> minor images, but certainly not logos and other important indicators.
>
> and perhaps one more:
>
> c. In some environments one may not want the images to be changeable
> by the skins, only by the templates themselves.
>
> I'm probably going to have to pull our current logo usage out of CSS and
> put it into the XHTML. *sigh*
>
> Murray
>
>> dirk
>>
>> On Wed, May 14, 2008 at 8:44 PM, Janne Jalkanen (JIRA) <ji...@apache.org>
>> wrote:
>>>
>>> [
>>> https://issues.apache.org/jira/browse/JSPWIKI-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596891#action_12596891
>>> ]
>>>
>>> Janne Jalkanen commented on JSPWIKI-208:
>>> ----------------------------------------
>>>
>>> Dirk, why on earth is the image placed in CSS instead of direct content?
>>>
>>> {code}
>>> <a class="feed" ... > </a>
>>> {code}
>>>
>>>> Hide RSS images if deactivated
>>>> ------------------------------
>>>>
>>>> Key: JSPWIKI-208
>>>> URL: https://issues.apache.org/jira/browse/JSPWIKI-208
>>>> Project: JSPWiki
>>>> Issue Type: Improvement
>>>> Components: Default template
>>>> Affects Versions: 2.6.0
>>>> Reporter: Cornelia Burko
>>>> Assignee: Janne Jalkanen
>>>> Priority: Minor
>>>> Fix For: 2.8
>>>>
>>>>
>>>> If the RSS feed is disabled in the jwpwiki.properties the image is still
>>>> shown beneath each article.
>>>> This one is not even marked by an specified css-class or id, so it could
>>>> not easily hidden via css.
>>>> The RSS image next to the jspwiki - version is hidden. It would be great
>>>> if the other images are hidden too.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>
>
>
> --
>
> ...........................................................................
> Murray Altheim <murray07 at altheim.com> === = =
> http://www.altheim.com/murray/ = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
>
Re: [jira] Commented: (JSPWIKI-208) Hide RSS images if deactivated
Posted by Murray Altheim <mu...@altheim.com>.
Dirk Frederickx wrote:
> Janne,
>
>
> This allows skins to change the image.
>
> This has been a generic approach throughout the new template. (logo's,
> other images, only the attachment icons still need to be handled)
> Ensure presentation stuff is moved to css, so it can be changed
> according the skins.
>
> In the below code snippit, the should actually be changed by a
> line-of-text, eg "RSS-feed", so things are still accessible when icons
> are not loaded.
The downside of this is twofold.
a. if JavaScript if off, the images aren't seen. This is not simply
an aesthetic issue -- it may also affect branding and is considered
by many site managers a Pretty Big Deal.
b. absent the <img> elements there is no 'alt' text, so accessibility
suffers. E.g., I just realized that we have a *requirement* (set
by the government) to provide accessible websites, and that includes
alt text on *all* images. (yuck) We can probably skirt by on the
minor images, but certainly not logos and other important indicators.
and perhaps one more:
c. In some environments one may not want the images to be changeable
by the skins, only by the templates themselves.
I'm probably going to have to pull our current logo usage out of CSS and
put it into the XHTML. *sigh*
Murray
> dirk
>
> On Wed, May 14, 2008 at 8:44 PM, Janne Jalkanen (JIRA) <ji...@apache.org> wrote:
>> [ https://issues.apache.org/jira/browse/JSPWIKI-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596891#action_12596891 ]
>>
>> Janne Jalkanen commented on JSPWIKI-208:
>> ----------------------------------------
>>
>> Dirk, why on earth is the image placed in CSS instead of direct content?
>>
>> {code}
>> <a class="feed" ... > </a>
>> {code}
>>
>>> Hide RSS images if deactivated
>>> ------------------------------
>>>
>>> Key: JSPWIKI-208
>>> URL: https://issues.apache.org/jira/browse/JSPWIKI-208
>>> Project: JSPWiki
>>> Issue Type: Improvement
>>> Components: Default template
>>> Affects Versions: 2.6.0
>>> Reporter: Cornelia Burko
>>> Assignee: Janne Jalkanen
>>> Priority: Minor
>>> Fix For: 2.8
>>>
>>>
>>> If the RSS feed is disabled in the jwpwiki.properties the image is still shown beneath each article.
>>> This one is not even marked by an specified css-class or id, so it could not easily hidden via css.
>>> The RSS image next to the jspwiki - version is hidden. It would be great if the other images are hidden too.
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
--
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: [jira] Commented: (JSPWIKI-208) Hide RSS images if deactivated
Posted by Dirk Frederickx <di...@gmail.com>.
Janne,
This allows skins to change the image.
This has been a generic approach throughout the new template. (logo's,
other images, only the attachment icons still need to be handled)
Ensure presentation stuff is moved to css, so it can be changed
according the skins.
In the below code snippit, the should actually be changed by a
line-of-text, eg "RSS-feed", so things are still accessible when icons
are not loaded.
dirk
On Wed, May 14, 2008 at 8:44 PM, Janne Jalkanen (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/JSPWIKI-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596891#action_12596891 ]
>
> Janne Jalkanen commented on JSPWIKI-208:
> ----------------------------------------
>
> Dirk, why on earth is the image placed in CSS instead of direct content?
>
> {code}
> <a class="feed" ... > </a>
> {code}
>
>> Hide RSS images if deactivated
>> ------------------------------
>>
>> Key: JSPWIKI-208
>> URL: https://issues.apache.org/jira/browse/JSPWIKI-208
>> Project: JSPWiki
>> Issue Type: Improvement
>> Components: Default template
>> Affects Versions: 2.6.0
>> Reporter: Cornelia Burko
>> Assignee: Janne Jalkanen
>> Priority: Minor
>> Fix For: 2.8
>>
>>
>> If the RSS feed is disabled in the jwpwiki.properties the image is still shown beneath each article.
>> This one is not even marked by an specified css-class or id, so it could not easily hidden via css.
>> The RSS image next to the jspwiki - version is hidden. It would be great if the other images are hidden too.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (JSPWIKI-208) Hide RSS images if deactivated
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596891#action_12596891 ]
Janne Jalkanen commented on JSPWIKI-208:
----------------------------------------
Dirk, why on earth is the image placed in CSS instead of direct content?
{code}
<a class="feed" ... > </a>
{code}
> Hide RSS images if deactivated
> ------------------------------
>
> Key: JSPWIKI-208
> URL: https://issues.apache.org/jira/browse/JSPWIKI-208
> Project: JSPWiki
> Issue Type: Improvement
> Components: Default template
> Affects Versions: 2.6.0
> Reporter: Cornelia Burko
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8
>
>
> If the RSS feed is disabled in the jwpwiki.properties the image is still shown beneath each article.
> This one is not even marked by an specified css-class or id, so it could not easily hidden via css.
> The RSS image next to the jspwiki - version is hidden. It would be great if the other images are hidden too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JSPWIKI-208) Hide RSS images if deactivated
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Janne Jalkanen resolved JSPWIKI-208.
------------------------------------
Resolution: Fixed
Fixed in 2.7.0-svn-45 by enhancing RSSImageLinkTag to also function with mode="wiki".
> Hide RSS images if deactivated
> ------------------------------
>
> Key: JSPWIKI-208
> URL: https://issues.apache.org/jira/browse/JSPWIKI-208
> Project: JSPWiki
> Issue Type: Improvement
> Components: Default template
> Affects Versions: 2.6.0
> Reporter: Cornelia Burko
> Assignee: Janne Jalkanen
> Priority: Minor
> Fix For: 2.8
>
>
> If the RSS feed is disabled in the jwpwiki.properties the image is still shown beneath each article.
> This one is not even marked by an specified css-class or id, so it could not easily hidden via css.
> The RSS image next to the jspwiki - version is hidden. It would be great if the other images are hidden too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.