You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/12 12:23:00 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #22117: Update Oracle DML SLELECT regression functions statement parse
Qianyi951015 opened a new pull request, #22117:
URL: https://github.com/apache/shardingsphere/pull/22117
Fixes #22116
Ref: https://docs.oracle.com/en/database/oracle/oracle-database/12.2/sqlrf/REGR_-Linear-Regression-Functions.html#GUID-A675B68F-2A88-4843-BE2C-FCDE9C65F9A9
<img width="722" alt="image" src="https://user-images.githubusercontent.com/57847965/201473665-02281b0f-0cd2-4bca-85a9-c999f6e2b6b9.png">
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22117: Update Oracle DML SLELECT regression functions statement parse
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #22117:
URL: https://github.com/apache/shardingsphere/pull/22117#discussion_r1020774602
##########
sql-parser/dialect/oracle/src/main/antlr4/imports/oracle/Number.g4:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+lexer grammar Number;
Review Comment:
Why add new Number.g4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22117: Update Oracle DML SLELECT regression functions statement parse
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22117:
URL: https://github.com/apache/shardingsphere/pull/22117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22117: Update Oracle DML SLELECT regression functions statement parse
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22117:
URL: https://github.com/apache/shardingsphere/pull/22117#discussion_r1020777875
##########
sql-parser/dialect/oracle/src/main/antlr4/imports/oracle/Number.g4:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+lexer grammar Number;
Review Comment:
I think it's because numbers don't fit in existing files like `Alphabet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22117: Update Oracle DML SLELECT regression functions statement parse
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22117:
URL: https://github.com/apache/shardingsphere/pull/22117#issuecomment-1312473910
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22117](https://codecov.io/gh/apache/shardingsphere/pull/22117?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9283d47) into [master](https://codecov.io/gh/apache/shardingsphere/commit/790e9d278064b2a41c3d2d5ec610a9bd3c8ca3da?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (790e9d2) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 9283d47 differs from pull request most recent head fb7e4d9. Consider uploading reports for the commit fb7e4d9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22117 +/- ##
=========================================
Coverage 61.15% 61.15%
Complexity 2544 2544
=========================================
Files 4109 4109
Lines 57162 57162
Branches 9680 9680
=========================================
Hits 34959 34959
Misses 19251 19251
Partials 2952 2952
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Qianyi951015 commented on a diff in pull request #22117: Update Oracle DML SLELECT regression functions statement parse
Posted by GitBox <gi...@apache.org>.
Qianyi951015 commented on code in PR #22117:
URL: https://github.com/apache/shardingsphere/pull/22117#discussion_r1020780717
##########
sql-parser/dialect/oracle/src/main/antlr4/imports/oracle/Number.g4:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+lexer grammar Number;
Review Comment:
@strongduanmu Cuz the keyword " REGR_R2" has number, I cannot add it to the keyword.g4 directly. I have discussed it with @RaigorJiang in the morning, and the solution we find out is to add a number.g4 file to solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22117: Update Oracle DML SLELECT regression functions statement parse
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #22117:
URL: https://github.com/apache/shardingsphere/pull/22117#discussion_r1020824663
##########
sql-parser/dialect/oracle/src/main/antlr4/imports/oracle/Number.g4:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+lexer grammar Number;
Review Comment:
Thank you for your explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org