You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "phongn (via GitHub)" <gi...@apache.org> on 2023/11/14 23:39:23 UTC
[PR] Remove HAVE_CPIO_H build var [trafficserver]
phongn opened a new pull request, #10783:
URL: https://github.com/apache/trafficserver/pull/10783
Replace automake-style `HAVE_INCLUDE_H` compile flags with `#if __has_include` preprocessor directives.
This PR does so for `cpio.h`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_CPIO_H build var [trafficserver]
Posted by "phongn (via GitHub)" <gi...@apache.org>.
phongn commented on PR #10783:
URL: https://github.com/apache/trafficserver/pull/10783#issuecomment-1815230557
> The second commit makes sense. CPIO does not seem to be used anywhere. We should be able to remove it.
Yes, I further investigated the original use of this and it appears unnecessary. See updated PR commit notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_CPIO_H build var [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10783:
URL: https://github.com/apache/trafficserver/pull/10783#issuecomment-1811651325
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_CPIO_H build var [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10783:
URL: https://github.com/apache/trafficserver/pull/10783#issuecomment-1811598263
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_CPIO_H build var [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #10783:
URL: https://github.com/apache/trafficserver/pull/10783#issuecomment-1815229661
The second commit makes sense. CPIO does not seem to be used anywhere. We should be able to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove HAVE_CPIO_H build var [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #10783:
URL: https://github.com/apache/trafficserver/pull/10783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org