You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/07/14 01:34:34 UTC
[jira] [Created] (HADOOP-8594) Upgrade to findbugs 2
Eli Collins created HADOOP-8594:
-----------------------------------
Summary: Upgrade to findbugs 2
Key: HADOOP-8594
URL: https://issues.apache.org/jira/browse/HADOOP-8594
Project: Hadoop Common
Issue Type: Bug
Components: build
Affects Versions: 2.0.0-alpha
Reporter: Eli Collins
Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Robert Joseph Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415125#comment-13415125 ]
Robert Joseph Evans commented on HADOOP-8594:
---------------------------------------------
I agree with Eli on this. Switching to a new findbugs is a great thing, but I don't want to break the pre-commit builds in the process. If we do that new findbugs issues will get past it simply because 54 looks a lot like 53 and it is simpler to say I didn't break it then to look at all 54 of the errors to see what the new ones might be.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Attachments: HADOOP-8594.patch, findbugs-2-html-reports.tar.gz, findbugs.html
>
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8594:
----------------------------
Attachment: findbugs.html
Here's a findbugs converted to HTML report over HDFS generated with the 2.5.1 version. Reports 53 new warnings.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Attachments: findbugs.html
>
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414319#comment-13414319 ]
Harsh J commented on HADOOP-8594:
---------------------------------
How should we address these individual projects though? Via sub-tasks or one global patch? I can do most of them, and compile a list we'd have to discuss about.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Attachments: HADOOP-8594.patch, findbugs-2-html-reports.tar.gz, findbugs.html
>
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414442#comment-13414442 ]
Eli Collins commented on HADOOP-8594:
-------------------------------------
Thanks Harsh, let's have a jira per project to switch over to the new plugin version and address the warnings in the patch that bumps the version.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Attachments: HADOOP-8594.patch, findbugs-2-html-reports.tar.gz, findbugs.html
>
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8594:
----------------------------
Attachment: findbugs-2-html-reports.tar.gz
Here's a list of all findbug reports across the hadoop project, in HTML and preserved in their own dirs, archived.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Attachments: HADOOP-8594.patch, findbugs-2-html-reports.tar.gz, findbugs.html
>
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476399#comment-13476399 ]
Arun C Murthy commented on HADOOP-8594:
---------------------------------------
Can you pls file one jira rather than tonnes to fix this? Thanks.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Attachments: findbugs-2-html-reports.tar.gz, findbugs.html, HADOOP-8594.patch
>
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-8594:
----------------------------
Attachment: HADOOP-8594.patch
Here's the patch that bumps the version. Had to do it in two places.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Attachments: HADOOP-8594.patch, findbugs.html
>
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8594) Upgrade to findbugs 2
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414279#comment-13414279 ]
Harsh J commented on HADOOP-8594:
---------------------------------
We currently use this version of findbugs-maven-plugin across hadoop trunk: http://mojo.codehaus.org/findbugs-maven-plugin-2.3.2/
Latest is 2.5.1 that uses 2.0.0 findbugs, at http://mojo.codehaus.org/findbugs-maven-plugin/
Making some changes to see if merely switching over works.
> Upgrade to findbugs 2
> ---------------------
>
> Key: HADOOP-8594
> URL: https://issues.apache.org/jira/browse/HADOOP-8594
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
>
> Harsh recently ran findbugs 2 (instead of 1.3.9 which is what jenkins runs) and it showed thousands of warnings (they've made a lot of progress in findbugs releases). We should upgrade to findbugs 2 and fix these.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira