You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Denis Magda <dm...@apache.org> on 2017/05/31 21:37:34 UTC

Persistent Store Stabilization for release

Igniters,

The Persistent Store donation was accepted by the community and now we should think of its readiness for a public release.

I know that many of you are involved it the donation stabilization. Could you share the current status of the feature? How far is it from the releasable state?

—
Denis

Re: Persistent Store Stabilization for release

Posted by Semyon Boikov <sb...@gridgain.com>.

Also in persistence code I see some TODOs (//TODO GG-), all TODOs should
reference some ingite JIRA issue,

Thanks!

On Fri, Jun 2, 2017 at 11:29 AM, Alexey Goncharuk <
alexey.goncharuk@gmail.com> wrote:

> Semyon, thanks for spotting this. I've removed the fails as tests should be
> passing now.
>
> 2017-06-02 10:20 GMT+03:00 Semyon Boikov <sb...@gridgain.com>:
>
> > Guys,
> >
> > I see some tests in PDS suite fail with message
> > "junit.framework.AssertionFailedError: only for one run, must be removed
> > soon". We never add suche messages without reference to JIRA issue,
> please
> > fix.
> >
> > Thanks!
> >
> > On Thu, Jun 1, 2017 at 7:22 PM, Alexey Goncharuk <
> > alexey.goncharuk@gmail.com
> > > wrote:
> >
> > > Guys,
> > >
> > > I merged recent changes from the master branch (SQL-related changes) to
> > the
> > > integration branch, we need another TC run to see if the merge broke
> > > something.
> > >
> > > 2017-06-01 19:14 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:
> > >
> > > > BTW, can anyone explain to me why do we keep the new persistence code
> > in
> > > a
> > > > separate module instead of merging it to core?
> > > >
> > > > On Thu, Jun 1, 2017 at 4:32 AM, Sergey Chugunov <
> > > sergey.chugunov@gmail.com
> > > > >
> > > > wrote:
> > > >
> > > > > Hello Denis,
> > > > >
> > > > > There are three suites [1] [2] [3] configured on TeamCity with
> bunch
> > of
> > > > > tests for PDS functionality.
> > > > >
> > > > > As you can see most of tests are passing now (only 6 tests are
> > > > > failing, for *partitionLoss
> > > > > *tests problem was almost sorted out), it looks like that this
> > > > > functionality is pretty stable.
> > > > >
> > > > >
> > > > > [1] Ignite PDS 1
> > > > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > > > Ignite20Tests_IgnitePds1&branch_Ignite20Tests=ignite-
> > > > > 5267&tab=buildTypeStatusDiv>
> > > > > [2] Ignite PDS 2
> > > > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > > > Ignite20Tests_IgnitePds2&branch_Ignite20Tests=ignite-
> > > > > 5267&tab=buildTypeStatusDiv>
> > > > > [3] Ignite OutOfMemory
> > > > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> > Ignite20Tests_
> > > > > IgnitePdsOutOfMemory&branch_Ignite20Tests=ignite-5267&tab=
> > > > > buildTypeStatusDiv>
> > > > >
> > > > > On Thu, Jun 1, 2017 at 1:24 AM, Dmitriy Setrakyan <
> > > dsetrakyan@apache.org
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Thanks Denis. I also would like to encourage to post all the
> > > > > stabilization
> > > > > > updates for the donated branch here. This will help the community
> > to
> > > > get
> > > > > > familiar with the new code and functionality.
> > > > > >
> > > > > > In addition, everyone in the community should feel free to peruse
> > > > through
> > > > > > the code in this branch and ask any questions that may come up:
> > > > > >
> > > > > > https://github.com/apache/ignite/tree/ignite-5267/modules/pds
> > > > > >
> > > > > > D.
> > > > > >
> > > > > >
> > > > > > On Wed, May 31, 2017 at 2:37 PM, Denis Magda <dm...@apache.org>
> > > > wrote:
> > > > > >
> > > > > > > Igniters,
> > > > > > >
> > > > > > > The Persistent Store donation was accepted by the community and
> > now
> > > > we
> > > > > > > should think of its readiness for a public release.
> > > > > > >
> > > > > > > I know that many of you are involved it the donation
> > stabilization.
> > > > > Could
> > > > > > > you share the current status of the feature? How far is it from
> > the
> > > > > > > releasable state?
> > > > > > >
> > > > > > > —
> > > > > > > Denis
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Persistent Store Stabilization for release

Posted by Alexey Goncharuk <al...@gmail.com>.

Semyon, thanks for spotting this. I've removed the fails as tests should be
passing now.

2017-06-02 10:20 GMT+03:00 Semyon Boikov <sb...@gridgain.com>:

> Guys,
>
> I see some tests in PDS suite fail with message
> "junit.framework.AssertionFailedError: only for one run, must be removed
> soon". We never add suche messages without reference to JIRA issue, please
> fix.
>
> Thanks!
>
> On Thu, Jun 1, 2017 at 7:22 PM, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> > wrote:
>
> > Guys,
> >
> > I merged recent changes from the master branch (SQL-related changes) to
> the
> > integration branch, we need another TC run to see if the merge broke
> > something.
> >
> > 2017-06-01 19:14 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:
> >
> > > BTW, can anyone explain to me why do we keep the new persistence code
> in
> > a
> > > separate module instead of merging it to core?
> > >
> > > On Thu, Jun 1, 2017 at 4:32 AM, Sergey Chugunov <
> > sergey.chugunov@gmail.com
> > > >
> > > wrote:
> > >
> > > > Hello Denis,
> > > >
> > > > There are three suites [1] [2] [3] configured on TeamCity with bunch
> of
> > > > tests for PDS functionality.
> > > >
> > > > As you can see most of tests are passing now (only 6 tests are
> > > > failing, for *partitionLoss
> > > > *tests problem was almost sorted out), it looks like that this
> > > > functionality is pretty stable.
> > > >
> > > >
> > > > [1] Ignite PDS 1
> > > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > > Ignite20Tests_IgnitePds1&branch_Ignite20Tests=ignite-
> > > > 5267&tab=buildTypeStatusDiv>
> > > > [2] Ignite PDS 2
> > > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > > Ignite20Tests_IgnitePds2&branch_Ignite20Tests=ignite-
> > > > 5267&tab=buildTypeStatusDiv>
> > > > [3] Ignite OutOfMemory
> > > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> Ignite20Tests_
> > > > IgnitePdsOutOfMemory&branch_Ignite20Tests=ignite-5267&tab=
> > > > buildTypeStatusDiv>
> > > >
> > > > On Thu, Jun 1, 2017 at 1:24 AM, Dmitriy Setrakyan <
> > dsetrakyan@apache.org
> > > >
> > > > wrote:
> > > >
> > > > > Thanks Denis. I also would like to encourage to post all the
> > > > stabilization
> > > > > updates for the donated branch here. This will help the community
> to
> > > get
> > > > > familiar with the new code and functionality.
> > > > >
> > > > > In addition, everyone in the community should feel free to peruse
> > > through
> > > > > the code in this branch and ask any questions that may come up:
> > > > >
> > > > > https://github.com/apache/ignite/tree/ignite-5267/modules/pds
> > > > >
> > > > > D.
> > > > >
> > > > >
> > > > > On Wed, May 31, 2017 at 2:37 PM, Denis Magda <dm...@apache.org>
> > > wrote:
> > > > >
> > > > > > Igniters,
> > > > > >
> > > > > > The Persistent Store donation was accepted by the community and
> now
> > > we
> > > > > > should think of its readiness for a public release.
> > > > > >
> > > > > > I know that many of you are involved it the donation
> stabilization.
> > > > Could
> > > > > > you share the current status of the feature? How far is it from
> the
> > > > > > releasable state?
> > > > > >
> > > > > > —
> > > > > > Denis
> > > > >
> > > >
> > >
> >
>

Re: Persistent Store Stabilization for release

Posted by Semyon Boikov <sb...@gridgain.com>.

Guys,

I see some tests in PDS suite fail with message
"junit.framework.AssertionFailedError: only for one run, must be removed
soon". We never add suche messages without reference to JIRA issue, please
fix.

Thanks!

On Thu, Jun 1, 2017 at 7:22 PM, Alexey Goncharuk <alexey.goncharuk@gmail.com
> wrote:

> Guys,
>
> I merged recent changes from the master branch (SQL-related changes) to the
> integration branch, we need another TC run to see if the merge broke
> something.
>
> 2017-06-01 19:14 GMT+03:00 Dmitriy Setrakyan <ds...@apache.org>:
>
> > BTW, can anyone explain to me why do we keep the new persistence code in
> a
> > separate module instead of merging it to core?
> >
> > On Thu, Jun 1, 2017 at 4:32 AM, Sergey Chugunov <
> sergey.chugunov@gmail.com
> > >
> > wrote:
> >
> > > Hello Denis,
> > >
> > > There are three suites [1] [2] [3] configured on TeamCity with bunch of
> > > tests for PDS functionality.
> > >
> > > As you can see most of tests are passing now (only 6 tests are
> > > failing, for *partitionLoss
> > > *tests problem was almost sorted out), it looks like that this
> > > functionality is pretty stable.
> > >
> > >
> > > [1] Ignite PDS 1
> > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > Ignite20Tests_IgnitePds1&branch_Ignite20Tests=ignite-
> > > 5267&tab=buildTypeStatusDiv>
> > > [2] Ignite PDS 2
> > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=
> > > Ignite20Tests_IgnitePds2&branch_Ignite20Tests=ignite-
> > > 5267&tab=buildTypeStatusDiv>
> > > [3] Ignite OutOfMemory
> > > <http://ci.ignite.apache.org/viewType.html?buildTypeId=Ignite20Tests_
> > > IgnitePdsOutOfMemory&branch_Ignite20Tests=ignite-5267&tab=
> > > buildTypeStatusDiv>
> > >
> > > On Thu, Jun 1, 2017 at 1:24 AM, Dmitriy Setrakyan <
> dsetrakyan@apache.org
> > >
> > > wrote:
> > >
> > > > Thanks Denis. I also would like to encourage to post all the
> > > stabilization
> > > > updates for the donated branch here. This will help the community to
> > get
> > > > familiar with the new code and functionality.
> > > >
> > > > In addition, everyone in the community should feel free to peruse
> > through
> > > > the code in this branch and ask any questions that may come up:
> > > >
> > > > https://github.com/apache/ignite/tree/ignite-5267/modules/pds
> > > >
> > > > D.
> > > >
> > > >
> > > > On Wed, May 31, 2017 at 2:37 PM, Denis Magda <dm...@apache.org>
> > wrote:
> > > >
> > > > > Igniters,
> > > > >
> > > > > The Persistent Store donation was accepted by the community and now
> > we
> > > > > should think of its readiness for a public release.
> > > > >
> > > > > I know that many of you are involved it the donation stabilization.
> > > Could
> > > > > you share the current status of the feature? How far is it from the
> > > > > releasable state?
> > > > >
> > > > > —
> > > > > Denis
> > > >
> > >
> >
>