You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ti...@apache.org on 2018/09/02 23:11:00 UTC

[mesos] branch master updated: Wrapped syscall initgroups by warning suppression pragma.

This is an automated email from the ASF dual-hosted git repository.

tillt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new 3f5f11d  Wrapped syscall initgroups by warning suppression pragma.
3f5f11d is described below

commit 3f5f11dd2aee7013e3a54329ec06601cb1ec0d5b
Author: Till Toenshoff <to...@me.com>
AuthorDate: Mon Sep 3 00:31:31 2018 +0200

    Wrapped syscall initgroups by warning suppression pragma.
    
    Review: https://reviews.apache.org/r/68604/
---
 3rdparty/stout/include/stout/os/posix/su.hpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/3rdparty/stout/include/stout/os/posix/su.hpp b/3rdparty/stout/include/stout/os/posix/su.hpp
index 715f888..11c5135 100644
--- a/3rdparty/stout/include/stout/os/posix/su.hpp
+++ b/3rdparty/stout/include/stout/os/posix/su.hpp
@@ -261,7 +261,14 @@ inline Try<Nothing> setgroups(
   // kernel cache, while the rest would still be performed
   // correctly by the kernel (asking Directory Service to resolve
   // the groups membership).
+
+  // We need to disable the deprecation warning as Apple has decided
+  // to deprecate all syscall functions with OS 10.12 (see MESOS-8457).
+  // We are using GCC pragmas also for covering clang.
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
   if (::syscall(SYS_initgroups, ngroups, _gids, uid.get()) == -1) {
+#pragma GCC diagnostic pop
     return ErrnoError();
   }
 #else