[GitHub] [incubator-mxnet] asmushetzel opened a new pull request #14356: support leading dimension of -1 in ravel/unravel

[GitBox <gi...@apache.org>]

asmushetzel opened a new pull request #14356: support leading dimension of -1 in ravel/unravel
URL: https://github.com/apache/incubator-mxnet/pull/14356
 
 
   ## Description ##
   Resolves issue #13862 . Using "-1" for the leading shape dimension was not officially documented but happened to work in versions 1.3.1 or lower as mshadow::index_t  was unsigned so -1 was eventually interpreted as maxint. In subsequent versions of mxnet, mshadow::index_t has been changed to a signed type such that using -1 as leading shape dimension did not work anymore.
   This fix documents that -1 is an allowed value for the leading dimension and re-enable behaviour of version 1.3.1.  Note that it is natural to assume that this use case is supported as the value of the leading dimension of the shape is not needed for ravel/unravel computations anyway. Also it seems from above issue, that there are valid customer use cases that need support for this. 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ X] Changes are complete (i.e. I finished coding on this PR)
   - [ X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services