[jira] [Commented] (OFBIZ-9443) Missing port.https configuration value breaks Solr

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071230#comment-16071230 ] 

Jacques Le Roux commented on OFBIZ-9443:
----------------------------------------

Hi Michael, I guess you refer to http://svn.apache.org/viewvc?view=revision&revision=1784930. I fear putting back a default value here will create some issues, at least on demos. Even if at the moment OFBIZ-9240 still needs to be resolved.

About
bq. This breaks the Solr functionality because it reads the ports for http/https from this file.
Actually only the default value for port.https has been removed because (as explained in the commit comment) the WebSiteProperties class "reuse the port initially found in the 1st login URL" and this has side effects when loging in/out. All this is initially related with HTTPS and HSTS.

I suggest to use this patch with default values, as it existed for HTTPS before r1784930 (HTTP port value did not change).
{code}
Index: plugins/solr/src/main/java/org/apache/ofbiz/solr/SolrUtil.java
===================================================================
--- plugins/solr/src/main/java/org/apache/ofbiz/solr/SolrUtil.java	(revision 1795779)
+++ plugins/solr/src/main/java/org/apache/ofbiz/solr/SolrUtil.java	(working copy)
 /**
  * Solr utility class.
@@ -85,7 +85,7 @@
         if (UtilValidate.isNotEmpty(solrWebappPortOverride)) {
             solrPort = solrWebappPortOverride;
         } else {
-            solrPort = UtilProperties.getPropertyValue("url", ("https".equals(solrWebappProtocol) ? "port.https" : "port.http"));
+            solrPort = UtilProperties.getPropertyValue("url", ("https".equals(solrWebappProtocol) ? "port.https" : "port.http"), ("https".equals(solrWebappProtocol) ? "8443" : "8080"));
         }
         
         return solrWebappProtocol + "://" + solrWebappDomainName + ":" + solrPort + solrWebappPath;
{code}



> Missing port.https configuration value breaks Solr
> --------------------------------------------------
>
>                 Key: OFBIZ-9443
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9443
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework, solr
>    Affects Versions: Trunk
>            Reporter: Michael Brohl
>
> Following OFBIZ-9206 the port.https value was removed from the configuration. This breaks the Solr functionality because it reads the ports for http/https from this file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)