[GitHub] [orc] stiga-huang commented on a change in pull request #877: ORC-959: [C++] Fix crash of SargsApplier in finding nested field names

[GitBox <gi...@apache.org>]

stiga-huang commented on a change in pull request #877:
URL: https://github.com/apache/orc/pull/877#discussion_r693612641



##########
File path: c++/src/sargs/SargsApplier.cc
##########
@@ -25,7 +25,8 @@ namespace orc {
   uint64_t SargsApplier::findColumn(const Type& type,
                                     const std::string& colName) {
     for (uint64_t i = 0; i != type.getSubtypeCount(); ++i) {
-      if (type.getFieldName(i) == colName) {
+      // Only STRUCT type has field names
+      if (type.getKind() == STRUCT && type.getFieldName(i) == colName) {

Review comment:
       No, predicate push down in the C++ reader is supported since 1.7.0. ORC-1.6.x doesn't have these codes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org