You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/11 09:39:27 UTC
[GitHub] [pulsar] yuruguo opened a new pull request, #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
yuruguo opened a new pull request, #16018:
URL: https://github.com/apache/pulsar/pull/16018
Fixes #12419
### Motivation
The pr-#15956 has been fixed the problem that role has `producer/consume` permission can’t get `v2/schema`, but it
missed `v1/schema`. So this pr solves the permission problem to get v1/schema.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1153166310
> @yuruguo There is a mailing list for discussing the V1 topic name https://lists.apache.org/thread/t3w9wjjkz4tfl5zwrmj44827vdpk2f4p
>
> I will remove the 2.10.1 label to unblock 2.10.1 release.
Thanks for your sharing @codelipenghui
In fact, this should belong to the same kind of question, that is, whether to continue to update or maintain the existing problems in the `v1` version.
I will continue to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1152897241
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Authorization] Fix producer/consume permission can’t get v1/schema [pulsar]
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1820357348
@yuruguo
This PR also fixed another issue that responds an incorrect HTTP header `Content-Encoding`. See the detail below:
```
curl -X GET -H "Content-Type:application/json" http://127.0.0.1:50040/admin/v2/schemas/my-property/my-ns/test-client-version/schema
{"version":0,"type":"STRING","timestamp":1700539331898,"data":"","properties":{}}
HTTP/1.1 200 OK
Date: Tue, 21 Nov 2023 06:33:45 GMT
broker-address: localhost
Content-Encoding: application/json
Content-Type: application/json
Content-Length: 81
Server: Jetty(9.4.51.v20230217)
```
https://github.com/apache/pulsar/pull/16018/files#diff-4bd0e9058034ada018ee4d5a4e8b950163b851e6933bf22298eb563947d54d2eL361-L362
I cherry-picked this PR into `branch-2.11`, @yuruguo Could you cherry-pick this PR into `branch-2.10`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1236478344
> We can do nothing after #16026 merged, because v1 & v2 schema both use `SchemasResourceBase` and this problem has
> been resolved in `SchemasResourceBase`.
OK, I will remove `release/2.10.2`. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1152900195
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1152949346
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1153146115
@yuruguo There is a mailing list for discussing the V1 topic name https://lists.apache.org/thread/t3w9wjjkz4tfl5zwrmj44827vdpk2f4p
I will remove the 2.10.1 label to unblock 2.10.1 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1231462017
@yuruguo Can you help cherry-pick this PR to branch-2.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1152953961
> Could you make these methods async?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
nodece commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1152949498
Could you make these methods async?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1183906309
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo closed pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo closed pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
URL: https://github.com/apache/pulsar/pull/16018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1153166486
> @yuruguo There is a mailing list for discussing the V1 topic name https://lists.apache.org/thread/t3w9wjjkz4tfl5zwrmj44827vdpk2f4p
>
> I will remove the 2.10.1 label to unblock 2.10.1 release.
Thanks for your sharing @codelipenghui
In fact, this should belong to the same kind of question, that is, whether to continue to update or maintain the existing problems in the v1 version. And I will continue to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo merged pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo merged PR #16018:
URL: https://github.com/apache/pulsar/pull/16018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #16018: [Authorization] Fix producer/consume permission can’t get v1/schema
Posted by GitBox <gi...@apache.org>.
yuruguo commented on PR #16018:
URL: https://github.com/apache/pulsar/pull/16018#issuecomment-1236372716
> @yuruguo Can you help cherry-pick this PR to branch-2.10
We can do nothing after #16026 merged, because v1 & v2 schema both use `SchemasResourceBase` and this problem has
been resolved in `SchemasResourceBase`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org