You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Jinho Kim <jh...@apache.org> on 2014/03/25 13:24:24 UTC

Review Request 19610: TAJO-705: CTAS always stores tables with CSV storage type into catalog

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19610/
-----------------------------------------------------------

Review request for Tajo.


Bugs: TAJO-705
    https://issues.apache.org/jira/browse/TAJO-705


Repository: tajo


Description
-------

Im


Diffs
-----

  tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 2ddbb177e9e5e26e502f414d53df33fa0b82a580 
  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java 48e3c936e3ed5aa2c74b6219b7a2415f45bcf72f 
  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java 8467b4bd2cf7e45568056ebf7cba0d014301fc29 
  tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java e61f509da4ef601e5a01cefc11d950f8bdde64b2 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithOptions.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithOptions.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithOptions.result PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithStoreType.result PRE-CREATION 

Diff: https://reviews.apache.org/r/19610/diff/


Testing
-------


Thanks,

Jinho Kim


Re: Review Request 19610: TAJO-705: CTAS always stores tables with CSV storage type into catalog

Posted by Jinho Kim <jh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19610/
-----------------------------------------------------------

(Updated March 25, 2014, 12:27 p.m.)


Review request for Tajo.


Bugs: TAJO-705
    https://issues.apache.org/jira/browse/TAJO-705


Repository: tajo


Description (updated)
-------

I'm suspecting that this bug is introduced recently.
The reproduction code is as follows:
tajo> create table rctest using rcfile as select * from region_100;
Progress: 100%, response time: 0.947 sec
final state: QUERY_SUCCEEDED, response time: 0.947 sec
OK
tajo> \d rctest;

table name: rctest
table path: hdfs://gruter102:6020/tajo/warehouse/rctest
store type: CSV
number of rows: 5
volume: 529 B
Options: 

schema: 
r_regionkey	INT8
r_name	TEXT
r_comment	TEXT
In this case, 'CSV' should be 'RCFILE'.


Diffs
-----

  tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 2ddbb177e9e5e26e502f414d53df33fa0b82a580 
  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java 48e3c936e3ed5aa2c74b6219b7a2415f45bcf72f 
  tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java 8467b4bd2cf7e45568056ebf7cba0d014301fc29 
  tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java e61f509da4ef601e5a01cefc11d950f8bdde64b2 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithOptions.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithOptions.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithOptions.result PRE-CREATION 
  tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithStoreType.result PRE-CREATION 

Diff: https://reviews.apache.org/r/19610/diff/


Testing (updated)
-------

mvn clean install


Thanks,

Jinho Kim