[jira] [Commented] (KAFKA-1042) Fix segment flush logic

["Neha Narkhede (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800910#comment-13800910 ] 

Neha Narkhede commented on KAFKA-1042:
--------------------------------------

Thanks for the follow up patch. Committed it to trunk

> Fix segment flush logic
> -----------------------
>
>                 Key: KAFKA-1042
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1042
>             Project: Kafka
>          Issue Type: Improvement
>          Components: log
>    Affects Versions: 0.8.1
>         Environment: centos6.4
>            Reporter: Joris Van Remoortere
>            Assignee: Jay Kreps
>            Priority: Critical
>              Labels: patch
>         Attachments: flush_segment_fix-v1.patch, flush_segment_fix-v3.patch, KAFKA-1042-v2.patch
>
>
> The logic for deciding which segments to flush in log.flush() was missing the case where the (from, to) range was within a single segment. This case enables some of the features in the server.properties file such as message volume / time based triggers for fsync on the log files.



--
This message was sent by Atlassian JIRA
(v6.1#6144)