[GitHub] spark pull request: [SPARK-2237][CORE]Add ZLIBCompressionCodec cod...

[mateiz <gi...@git.apache.org>]

Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/1121#issuecomment-53973370
  
    @YanjieGao do you see a major tradeoff in compressed size and speed with this codec over our current ones?
    
    Also, I'm not sure your patch will compile as written. There's no Maven dependency on this ZLib library and there seem to be two classes called CompressionSuite. I'm also way to add something that depends on this small third-party library -- would be better to use Java's built-in GzipOutputStream.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org