[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #257: [OAP Integration] Register missing TopN registry service

["lujiajing1126 (via GitHub)" <gi...@apache.org>]

lujiajing1126 commented on PR #257:
URL: https://github.com/apache/skywalking-banyandb/pull/257#issuecomment-1455076649

   Basically, it works for multiple groups.
   
   Still two issues,
   
   ### How can we serialize `seriesID` of the original measure
   
   The current protocol for `seriesID` in the response is `string` as `name` field. In order to deserialize it properly, we may need a more sophisticated design.
   
   ### How to elegantly disable NULL group
   
   From the issue https://github.com/apache/skywalking/issues/10472, quoted
   
   > If you don't want to generate such a group, TopNAggregation{criteria:service_id!=null}. != is the BINARY_OP_NE. The result would be like this: service1:[endpoint1:100...], service2:[endpoint2:90]...
   
   I totally disagree with this design which would mix a nested filter for source measure with options of `TopN` streaming operator. We may add `disableNullGroup` to the `TopNAggregation` schema.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org