[jira] [Commented] (SOLR-9069) Cleanup/rename confusion of shardCount in tests actually being serverCount

["Alan Woodward (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271153#comment-15271153 ] 

Alan Woodward commented on SOLR-9069:
-------------------------------------

My suggestion: nuke BaseDistributedSearchTestCase entirely and migrate everything to SolrCloudTestCase.  I'm going to be working on that this week...

> Cleanup/rename confusion of shardCount in tests actually being serverCount
> --------------------------------------------------------------------------
>
>                 Key: SOLR-9069
>                 URL: https://issues.apache.org/jira/browse/SOLR-9069
>             Project: Solr
>          Issue Type: Test
>          Components: Tests
>            Reporter: David Smiley
>
> BaseDistributedSearchTestCase has a shardCount field, which can be set directly or via the {{\@ShardsFixed}} annotation.  For some (esp. older) tests, this is in fact the number of "shards" (disjoint slices of your overall data), but it's also the number of Solr/Jetty servers/nodes.  Subclasses like AbstractFullDistribZkTestBase define sliceCount, adding to the confusion, and define however many shards (slices) they want -- separately from the number of servers (which is configured confusingly, as stated, via ShardsFixed).  This is confusing!  I'm not 100% sure what the solution is, I'll suggest some ideas, but we should discuss.
> Of course we got to this situation historically before SolrCloud existed; no excuses needed.  Now we should fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org