[GitHub] [iotdb] JackieTien97 commented on a change in pull request #1917: Add restrictions for LAST query filter

[GitBox <gi...@apache.org>]

JackieTien97 commented on a change in pull request #1917:
URL: https://github.com/apache/iotdb/pull/1917#discussion_r515956741



##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/LastQueryExecutor.java
##########
@@ -145,13 +145,17 @@ public static TimeValuePair calculateLastPairForOneSeriesLocally(
         TimeValuePair timeValuePair = IoTDB.metaManager.getLastCache(seriesPath);
         if (timeValuePair != null && satisfyFilter(filter, timeValuePair)) {
           return timeValuePair;
+        } else if (timeValuePair != null) {
+          return null;
         }
       }
 
       if (node != null && node.getCachedLast() != null) {
         TimeValuePair timeValuePair =  node.getCachedLast();
         if (timeValuePair != null && satisfyFilter(filter, timeValuePair)) {
           return timeValuePair;
+        } else if (timeValuePair != null) {
+          return null;

Review comment:
       If the cached last time-value pair doesn't satify the filter, shouldn't we keep to call the calculateLastPairByScanningTsFiles() function?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org