You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/09 23:07:28 UTC

[GitHub] [arrow] emkornfield commented on pull request #8417: WIP: [C++] Get rid of code duplication in Decimal##bit_width

emkornfield commented on pull request #8417:
URL: https://github.com/apache/arrow/pull/8417#issuecomment-706437971


   I can look in a bit more detail but two high level comments:
   1.  Lets not use macros in the header files for declaration. 
    The [style guide strongly discourages it](https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros)
   2.  For the Base decimal type, we need to make sure that this doesn't break Gandiva in some way (I wouldn't expect it to but the reason for the separation was because certain headers don't play well will LLVM).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org