You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/04/20 17:14:55 UTC

[GitHub] piiswrong commented on a change in pull request #10623: [MXNET-339] Add warning on input data for RNN for layout NTC

piiswrong commented on a change in pull request #10623: [MXNET-339] Add warning on input data for RNN for layout NTC
URL: https://github.com/apache/incubator-mxnet/pull/10623#discussion_r183115582
 
 

 ##########
 File path: python/mxnet/gluon/rnn/rnn_layer.py
 ##########
 @@ -286,6 +286,9 @@ class RNN(_RNNLayer):
     Inputs:
         - **data**: input tensor with shape `(sequence_length, batch_size, input_size)`
           when `layout` is "TNC". For other layouts dimensions are permuted accordingly.
+          Be aware that a `transpose` operation with a ndarray results in a new allocation of
 
 Review comment:
   Looks too long. Just adding a short sentence a long the line of "TNC is faster" should be enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services