You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/10/31 13:29:33 UTC
[jira] [Commented] (SHINDIG-1654) Remove unused configuration in
shindig.properties for proxy and concat urls
[ https://issues.apache.org/jira/browse/SHINDIG-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140089#comment-13140089 ]
jiraposter@reviews.apache.org commented on SHINDIG-1654:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2640/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.
shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&
This addresses bug SHINDIG-1654.
https://issues.apache.org/jira/browse/SHINDIG-1654
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1190346
Diff: https://reviews.apache.org/r/2640/diff
Testing
-------
Build/Junit passed
Thanks,
Stanton
> Remove unused configuration in shindig.properties for proxy and concat urls
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1654
> URL: https://issues.apache.org/jira/browse/SHINDIG-1654
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Trivial
> Fix For: 3.0.0
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> The following lines in shindig.properties have been deprecated in favor of defining them in container.js. It seems they were implemented in container.js but the old configuration was never removed.
> shindig.content-rewrite.proxy-url=%contextRoot%/gadgets/proxy?container=default&url=
> shindig.content-rewrite.concat-url=%contextRoot%/gadgets/concat?container=default&
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira