You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Kennard Consulting (JIRA)" <de...@myfaces.apache.org> on 2010/10/01 06:26:33 UTC
[jira] Created: (MYFACES-2935) SystemEvent Acid Test
SystemEvent Acid Test
---------------------
Key: MYFACES-2935
URL: https://issues.apache.org/jira/browse/MYFACES-2935
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.2
Reporter: Kennard Consulting
Hi guys,
First - thanks for the great work you do with MyFaces. It's an awesome product and it's wonderful to have an independent implementation of the JSF spec!
I am the author of Metawidget (http://metawidget.org), a JSF component that does a lot of runtime component tree manipulation. This was unreliable under JSF 1, but JSF 2 introduced SystemEvents which promise to make this more solid. I believe Metawidget exercises SystemEvents more than most, and as such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
As a bit of fun I have created a small Acid Test (inspired by http://acidtests.org) for SystemEvents. I would be most grateful if you could work through the 3 tests and get MyFaces working with them. Basically the tests all use a combination of PreRenderViewEvent and tree manipulation. Full instructions are included on each JSF page. Of course, there may be bugs in the test itself in which case feel free to point them out :)
Regards,
Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2935) SystemEvent Acid Test
Posted by "Kennard Consulting (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917484#action_12917484 ]
Kennard Consulting commented on MYFACES-2935:
---------------------------------------------
Leonardo,
Wow. Just wow.
I can't tell you how impressed I am with the speed of your responses. I am happy to report the nightly build works really well both with the Acid Test and within Metawidget proper. You can now consider this issue closed.
I'm thrilled to be able to say Metawidget works properly on JSF 2, and look forward to the MyFaces 2.0.3 release!
Thanks again,
Richard.
> SystemEvent Acid Test
> ---------------------
>
> Key: MYFACES-2935
> URL: https://issues.apache.org/jira/browse/MYFACES-2935
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.2
> Reporter: Kennard Consulting
> Attachments: EventTest.myfaces.4.zip, EventTest.myfaces.zip
>
>
> Hi guys,
> First - thanks for the great work you do with MyFaces. It's an awesome product and it's wonderful to have an independent implementation of the JSF spec!
> I am the author of Metawidget (http://metawidget.org), a JSF component that does a lot of runtime component tree manipulation. This was unreliable under JSF 1, but JSF 2 introduced SystemEvents which promise to make this more solid. I believe Metawidget exercises SystemEvents more than most, and as such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
> As a bit of fun I have created a small Acid Test (inspired by http://acidtests.org) for SystemEvents. I would be most grateful if you could work through the 3 tests and get MyFaces working with them. Basically the tests all use a combination of PreRenderViewEvent and tree manipulation. Full instructions are included on each JSF page. Of course, there may be bugs in the test itself in which case feel free to point them out :)
> Regards,
> Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2935) SystemEvent Acid Test
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2935.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-SNAPSHOT
Assignee: Leonardo Uribe
Hi Richard
Ok, good to know that. Thanks a lot for the examples, that helps a lot to identify and solve the issues fast.
> SystemEvent Acid Test
> ---------------------
>
> Key: MYFACES-2935
> URL: https://issues.apache.org/jira/browse/MYFACES-2935
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.2
> Reporter: Kennard Consulting
> Assignee: Leonardo Uribe
> Fix For: 2.0.3-SNAPSHOT
>
> Attachments: EventTest.myfaces.4.zip, EventTest.myfaces.zip
>
>
> Hi guys,
> First - thanks for the great work you do with MyFaces. It's an awesome product and it's wonderful to have an independent implementation of the JSF spec!
> I am the author of Metawidget (http://metawidget.org), a JSF component that does a lot of runtime component tree manipulation. This was unreliable under JSF 1, but JSF 2 introduced SystemEvents which promise to make this more solid. I believe Metawidget exercises SystemEvents more than most, and as such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
> As a bit of fun I have created a small Acid Test (inspired by http://acidtests.org) for SystemEvents. I would be most grateful if you could work through the 3 tests and get MyFaces working with them. Basically the tests all use a combination of PreRenderViewEvent and tree manipulation. Full instructions are included on each JSF page. Of course, there may be bugs in the test itself in which case feel free to point them out :)
> Regards,
> Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2935) SystemEvent Acid Test
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917220#action_12917220 ]
Leonardo Uribe commented on MYFACES-2935:
-----------------------------------------
Thanks for the examples. It helps a lot to indentify and solve the issues. I have committed two fixes on trunk:
1. Prevent add components twice on restore and remove duplicate ids.
2. View system listeners could be added when a event like PreRenderView is being processed, so an alternate algorithm dealing with this condition is necessary.
So now Myfaces pass 3/3. If you have more test to do I'll keep an eye on this issue. If those were all required tests let me know, so I can close this issue as fixed.
> SystemEvent Acid Test
> ---------------------
>
> Key: MYFACES-2935
> URL: https://issues.apache.org/jira/browse/MYFACES-2935
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.2
> Reporter: Kennard Consulting
> Attachments: EventTest.myfaces.zip
>
>
> Hi guys,
> First - thanks for the great work you do with MyFaces. It's an awesome product and it's wonderful to have an independent implementation of the JSF spec!
> I am the author of Metawidget (http://metawidget.org), a JSF component that does a lot of runtime component tree manipulation. This was unreliable under JSF 1, but JSF 2 introduced SystemEvents which promise to make this more solid. I believe Metawidget exercises SystemEvents more than most, and as such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
> As a bit of fun I have created a small Acid Test (inspired by http://acidtests.org) for SystemEvents. I would be most grateful if you could work through the 3 tests and get MyFaces working with them. Basically the tests all use a combination of PreRenderViewEvent and tree manipulation. Full instructions are included on each JSF page. Of course, there may be bugs in the test itself in which case feel free to point them out :)
> Regards,
> Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2935) SystemEvent Acid Test
Posted by "Kennard Consulting (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917056#action_12917056 ]
Kennard Consulting commented on MYFACES-2935:
---------------------------------------------
I should mention that MyFaces 2.0.2 passes 1/3 of the Acid Tests.
Mojarra 2.0.3 passes 0/3, but they have recently done some fixes in their nightly builds so that now they pass 2/3.
I'd be hugely grateful if you could download it and at least confirm you can reproduce the problem. Then we can have a fight to see which team passes the Acid Test first!
> SystemEvent Acid Test
> ---------------------
>
> Key: MYFACES-2935
> URL: https://issues.apache.org/jira/browse/MYFACES-2935
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.2
> Reporter: Kennard Consulting
> Attachments: EventTest.myfaces.zip
>
>
> Hi guys,
> First - thanks for the great work you do with MyFaces. It's an awesome product and it's wonderful to have an independent implementation of the JSF spec!
> I am the author of Metawidget (http://metawidget.org), a JSF component that does a lot of runtime component tree manipulation. This was unreliable under JSF 1, but JSF 2 introduced SystemEvents which promise to make this more solid. I believe Metawidget exercises SystemEvents more than most, and as such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
> As a bit of fun I have created a small Acid Test (inspired by http://acidtests.org) for SystemEvents. I would be most grateful if you could work through the 3 tests and get MyFaces working with them. Basically the tests all use a combination of PreRenderViewEvent and tree manipulation. Full instructions are included on each JSF page. Of course, there may be bugs in the test itself in which case feel free to point them out :)
> Regards,
> Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2935) SystemEvent Acid Test
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917456#action_12917456 ]
Leonardo Uribe commented on MYFACES-2935:
-----------------------------------------
I committed two new fixes:
1. The order of added clientIds is critical to restore the tree properly (the tests done before 2.0.2 were too simple to detect this precondition, but we have to take that into account and construct that list when view is being saved).
2. A ConcurrentModificationException is thrown when we remove components, because we are manipulating the removed clientids list without real need, so we need a check for that condition. The order for removed clientIds does not matter in this case, but anyway use a Set for remove duplicates is ok.
Some junit tests were added to, based on the proposed tests. Now myfaces pass 4/4 tests.
> SystemEvent Acid Test
> ---------------------
>
> Key: MYFACES-2935
> URL: https://issues.apache.org/jira/browse/MYFACES-2935
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.2
> Reporter: Kennard Consulting
> Attachments: EventTest.myfaces.4.zip, EventTest.myfaces.zip
>
>
> Hi guys,
> First - thanks for the great work you do with MyFaces. It's an awesome product and it's wonderful to have an independent implementation of the JSF spec!
> I am the author of Metawidget (http://metawidget.org), a JSF component that does a lot of runtime component tree manipulation. This was unreliable under JSF 1, but JSF 2 introduced SystemEvents which promise to make this more solid. I believe Metawidget exercises SystemEvents more than most, and as such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
> As a bit of fun I have created a small Acid Test (inspired by http://acidtests.org) for SystemEvents. I would be most grateful if you could work through the 3 tests and get MyFaces working with them. Basically the tests all use a combination of PreRenderViewEvent and tree manipulation. Full instructions are included on each JSF page. Of course, there may be bugs in the test itself in which case feel free to point them out :)
> Regards,
> Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2935) SystemEvent Acid Test
Posted by "Kennard Consulting (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917281#action_12917281 ]
Kennard Consulting commented on MYFACES-2935:
---------------------------------------------
Leonardo,
Thank you so much for your quick response! I am thrilled to confirm I have downloaded your fixes from SVN and all 3/3 tests now pass.
When putting the new MyFaces JAR into Metawidget, things get *much* further, but I must apologise because it is hard for me to know what other bugs may be lurking. And, in fact, there is (at least) one more.
I have updated EventTest.myfaces.zip with a further fourth test. I stayed within the existing EventTest because it is important all the tests work together. I would be most grateful if you could investigate the new test 4 (stable.jsf) and let me know how you go.
Regards,
Richard.
> SystemEvent Acid Test
> ---------------------
>
> Key: MYFACES-2935
> URL: https://issues.apache.org/jira/browse/MYFACES-2935
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.2
> Reporter: Kennard Consulting
> Attachments: EventTest.myfaces.zip
>
>
> Hi guys,
> First - thanks for the great work you do with MyFaces. It's an awesome product and it's wonderful to have an independent implementation of the JSF spec!
> I am the author of Metawidget (http://metawidget.org), a JSF component that does a lot of runtime component tree manipulation. This was unreliable under JSF 1, but JSF 2 introduced SystemEvents which promise to make this more solid. I believe Metawidget exercises SystemEvents more than most, and as such I am seeing problems both in MyFaces (2.0.2) and in Mojarra (2.0.3).
> As a bit of fun I have created a small Acid Test (inspired by http://acidtests.org) for SystemEvents. I would be most grateful if you could work through the 3 tests and get MyFaces working with them. Basically the tests all use a combination of PreRenderViewEvent and tree manipulation. Full instructions are included on each JSF page. Of course, there may be bugs in the test itself in which case feel free to point them out :)
> Regards,
> Richard.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.