You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2015/03/05 15:09:23 UTC
Re: Review Request 31564: DISPATCH-101: Clarify the interator API by
renaming those methods that are specific to address field handling.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31564/#review75331
-----------------------------------------------------------
Ship it!
Spot onl comments are trivial.
trunk/tests/field_test.c
<https://reviews.apache.org/r/31564/#comment122313>
No need for leading `_` on static function, name can't clash outside the file.
trunk/tests/field_test.c
<https://reviews.apache.org/r/31564/#comment122314>
ditto leading `_`
- Alan Conway
On Feb. 27, 2015, 10:45 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31564/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 10:45 p.m.)
>
>
> Review request for qpid, Alan Conway, michael goulish, and Ted Ross.
>
>
> Bugs: DISPATCH-101
> https://issues.apache.org/jira/browse/DISPATCH-101
>
>
> Repository: qpid-dispatch
>
>
> Description
> -------
>
> Those iterator methods that deal with address-specific operations (e.g. 'views') are renamed to include 'address' in their names.
>
> Add alias constructors that default the view for non-address fields.
>
> Explicitly denote those methods that do not change the state of an iterator (const).
>
> Improve/optimize the cursor advance logic.
>
>
> Diffs
> -----
>
> trunk/include/qpid/dispatch/iterator.h 1662560
> trunk/src/container.c 1662560
> trunk/src/iterator.c 1662560
> trunk/src/lrp.c 1662560
> trunk/src/message.c 1662560
> trunk/src/router_config.c 1662560
> trunk/src/router_node.c 1662560
> trunk/src/router_pynode.c 1662560
> trunk/src/waypoint.c 1662560
> trunk/tests/field_test.c 1662560
> trunk/tests/parse_test.c 1662560
>
> Diff: https://reviews.apache.org/r/31564/diff/
>
>
> Testing
> -------
>
> Added interator cursor advance tests (both string and buffer based).
>
> Added buffer based address hashing test.
>
>
> Thanks,
>
> Kenneth Giusti
>
>