[GitHub] spark pull request: [SPARK-4937][SQL] Adding optimization to simpl...

[liancheng <gi...@git.apache.org>]

Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/3778#issuecomment-67987903
  
    Hey @scwf, I'm kinda lost in all the predicates provided in the PR description... Would you mind to provide several simpler cases to illustrate what kind of optimizations this PR enables?
    
    I guess essentially the second case is this:
    
    1. `(a && b) || (a && c)` is turned into `a && (b || c)`,
    2. `a` happens to be a join key equality comparison, thus forms an equi-join
    3. the cartesian product is replaced by a shuffle join
    
    Is it correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org