You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "raiden00pl (via GitHub)" <gi...@apache.org> on 2023/02/07 13:51:23 UTC
[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1550: examples/timer_gpio: fix compilation
raiden00pl opened a new pull request, #1550:
URL: https://github.com/apache/nuttx-apps/pull/1550
## Summary
examples/timer_gpio: fix compilation
Broken since 9368b659a763faa4e45b657ea71922b651751aa5
## Impact
## Testing
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1550: examples/timer_gpio: fix compilation
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #1550:
URL: https://github.com/apache/nuttx-apps/pull/1550#discussion_r1098869361
##########
examples/timer_gpio/timer_gpio_main.c:
##########
@@ -184,7 +184,6 @@ static int timer_gpio_daemon(int argc, char *argv[])
notify.event.sigev_notify = SIGEV_SIGNAL;
notify.event.sigev_signo = CONFIG_EXAMPLES_TIMER_GPIO_SIGNO;
notify.event.sigev_value.sival_ptr = NULL;
- notify.oneshot = false;
Review Comment:
I think `oneshot` was renamed to `periodic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] raiden00pl commented on a diff in pull request #1550: examples/timer_gpio: fix compilation
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on code in PR #1550:
URL: https://github.com/apache/nuttx-apps/pull/1550#discussion_r1098872860
##########
examples/timer_gpio/timer_gpio_main.c:
##########
@@ -184,7 +184,6 @@ static int timer_gpio_daemon(int argc, char *argv[])
notify.event.sigev_notify = SIGEV_SIGNAL;
notify.event.sigev_signo = CONFIG_EXAMPLES_TIMER_GPIO_SIGNO;
notify.event.sigev_value.sival_ptr = NULL;
- notify.oneshot = false;
Review Comment:
It's already here https://github.com/apache/nuttx-apps/blob/c57e7a7b81d373c64b2a31708f68661e7f717b5b/examples/timer_gpio/timer_gpio_main.c#L182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1550: examples/timer_gpio: fix compilation
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1550:
URL: https://github.com/apache/nuttx-apps/pull/1550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org