[jira] [Commented] (CALCITE-619) Slim down dependencies in parent POM

["Vladimir Sitnikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14489188#comment-14489188 ] 

Vladimir Sitnikov commented on CALCITE-619:
-------------------------------------------

Please clarify:
1) Why did you expand {{project.version}}? I would prefer to keep variable there to minimize "update version diff"
{noformat}
-        <version>${project.version}</version>
+        <version>1.2.0-incubating-SNAPSHOT</version>
{noformat}

2) Don't you think we'd better trim {{<version>1.2.0-incubating</version>}} from child modules, so the version is inherited from parent pom?

3) We'd better move "annotations" to provided scope. The following change is not required.
If annotation is missing on the runtime class path, then class/method works as usual. You just can't get the annotation value.

I would vote for using {{@Nullable}}, etc annotations for easier code read and/or for static analyzers. It is free from the "additional dependencies" point of view. We just need to use {{provided}} for that

{noformat}
@@ -20,7 +20,6 @@ import java.sql.ResultSetMetaData;
 import java.sql.SQLException;
 import java.util.Properties;
 import java.util.TimeZone;
-import javax.annotation.Nullable;
 
 /**
  * Factory for JDBC objects.
@@ -39,11 +38,11 @@ public interface AvaticaFactory {
       Properties info) throws SQLException;
 
   AvaticaStatement newStatement(AvaticaConnection connection,
-      @Nullable Meta.StatementHandle h, int resultSetType,
+      /*@Nullable*/ Meta.StatementHandle h, int resultSetType,
       int resultSetConcurrency, int resultSetHoldability) throws SQLException;
 
   AvaticaPreparedStatement newPreparedStatement(AvaticaConnection connection,
-      @Nullable Meta.StatementHandle h, Meta.Signature signature,
+      /*@Nullable*/ Meta.StatementHandle h, Meta.Signature signature,
       int resultSetType, int resultSetConcurrency, int resultSetHoldability)
       throws SQLException;{noformat}

> Slim down dependencies in parent POM
> ------------------------------------
>
>                 Key: CALCITE-619
>                 URL: https://issues.apache.org/jira/browse/CALCITE-619
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>             Fix For: 1.2.0-incubating
>
>
> Calcite's parent POM currently has a long dependency list, but that list should be short, or even empty.
> The parent POM should (and does) have a dependencyManagement section that specifies versions, but each module should have a dependencies section containing the dependencies that it actually uses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)