You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2009/11/23 16:47:48 UTC
svn commit: r883379 - in /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp: TestDelegatingConnection.java TestPoolingDataSource.java managed/TestManagedDataSource.java

Author: markt
Date: Mon Nov 23 15:47:47 2009
New Revision: 883379

URL: http://svn.apache.org/viewvc?rev=883379&view=rev
Log:
Fix FindBugs warnings
Make inner classes static where possible

Modified:
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDelegatingConnection.java
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolingDataSource.java
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestManagedDataSource.java

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDelegatingConnection.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDelegatingConnection.java?rev=883379&r1=883378&r2=883379&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDelegatingConnection.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestDelegatingConnection.java Mon Nov 23 15:47:47 2009
@@ -141,7 +141,7 @@
      * Delegate that will throw RTE on toString
      * Used to validate fix for DBCP-241
      */
-    class RTEGeneratingConnection extends TesterConnection {
+    static class RTEGeneratingConnection extends TesterConnection {
         public RTEGeneratingConnection() {
             super("","");
         }

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolingDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolingDataSource.java?rev=883379&r1=883378&r2=883379&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolingDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestPoolingDataSource.java Mon Nov 23 15:47:47 2009
@@ -157,8 +157,8 @@
     }
     
     /** Factory to return non-delegating connections for DBCP-198 test */
-    private class NonDelegatingPoolableConnectionFactory extends
-        PoolableConnectionFactory {
+    private static class NonDelegatingPoolableConnectionFactory
+            extends PoolableConnectionFactory {
         public NonDelegatingPoolableConnectionFactory(ConnectionFactory connFactory, ObjectPool pool) {
             super(connFactory, pool, null, null, true, true);
         }

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestManagedDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestManagedDataSource.java?rev=883379&r1=883378&r2=883379&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestManagedDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestManagedDataSource.java Mon Nov 23 15:47:47 2009
@@ -235,7 +235,8 @@
     /**
      * Factory to return non-delegating connections for DBCP-198 test
      */
-    private class NonDelegatingPoolableConnectionFactory extends PoolableConnectionFactory {
+    private static class NonDelegatingPoolableConnectionFactory
+            extends PoolableConnectionFactory {
         public NonDelegatingPoolableConnectionFactory(ConnectionFactory connFactory, ObjectPool pool) {
             super(connFactory, pool, null, null, true, true);
         }