You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/20 18:55:15 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #6944: [DOCS] Improve windows build instruction via conda
tqchen opened a new pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944
cc @tmoreau89 @jroesch @junrushao1994 @rkimball
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6944: [DOCS] Improve windows build instruction via conda
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944#discussion_r527957414
##########
File path: docs/install/from_source.rst
##########
@@ -122,27 +122,56 @@ The configuration of TVM can be modified by `config.cmake`.
If everything goes well, we can go to :ref:`python-package-installation`
+.. _build-with-conda:
+
+Building with a Conda Environment
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Conda is a very handy way to the necessary obtain dependencies needed for running TVM.
+First, follow the `conda's installation guide <https://docs.conda.io/projects/conda/en/latest/user-guide/install/>`_
+to install miniconda or anaconda if you do not yet have conda in your system. Run the following command in a conda environment:
+
+.. code:: bash
+
+ conda env update -f conda/build-environment.yaml
+ conda activate tvm-build
+
Review comment:
I actually checked, conda env update create also creates the env(when the original name exists), and conda env create will error out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6944: [DOCS] Improve windows build instruction via conda
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944#discussion_r527931922
##########
File path: docs/install/from_source.rst
##########
@@ -122,27 +122,56 @@ The configuration of TVM can be modified by `config.cmake`.
If everything goes well, we can go to :ref:`python-package-installation`
+.. _build-with-conda:
+
+Building with a Conda Environment
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Conda is a very handy way to the necessary obtain dependencies needed for running TVM.
+First, follow the `conda's installation guide <https://docs.conda.io/projects/conda/en/latest/user-guide/install/>`_
+to install miniconda or anaconda if you do not yet have conda in your system. Run the following command in a conda environment:
+
+.. code:: bash
+
+ conda env update -f conda/build-environment.yaml
+ conda activate tvm-build
+
Review comment:
1) It is better to create a new env with the yaml file you provide: https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-from-an-environment-yml-file
2) Document what these lines are doing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6944: [DOCS] Improve windows build instruction via conda
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944#discussion_r527931922
##########
File path: docs/install/from_source.rst
##########
@@ -122,27 +122,56 @@ The configuration of TVM can be modified by `config.cmake`.
If everything goes well, we can go to :ref:`python-package-installation`
+.. _build-with-conda:
+
+Building with a Conda Environment
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Conda is a very handy way to the necessary obtain dependencies needed for running TVM.
+First, follow the `conda's installation guide <https://docs.conda.io/projects/conda/en/latest/user-guide/install/>`_
+to install miniconda or anaconda if you do not yet have conda in your system. Run the following command in a conda environment:
+
+.. code:: bash
+
+ conda env update -f conda/build-environment.yaml
+ conda activate tvm-build
+
Review comment:
1) It is better to create a new env with the yaml file you provide: https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-from-an-environment-yml-file
2) Document what these lines are doing
3) Document conda/build-environment.yaml is under TVM's source tree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6944: [DOCS] Improve windows build instruction via conda
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944#discussion_r527957414
##########
File path: docs/install/from_source.rst
##########
@@ -122,27 +122,56 @@ The configuration of TVM can be modified by `config.cmake`.
If everything goes well, we can go to :ref:`python-package-installation`
+.. _build-with-conda:
+
+Building with a Conda Environment
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Conda is a very handy way to the necessary obtain dependencies needed for running TVM.
+First, follow the `conda's installation guide <https://docs.conda.io/projects/conda/en/latest/user-guide/install/>`_
+to install miniconda or anaconda if you do not yet have conda in your system. Run the following command in a conda environment:
+
+.. code:: bash
+
+ conda env update -f conda/build-environment.yaml
+ conda activate tvm-build
+
Review comment:
Thanks, updated per comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6944: [DOCS] Improve windows build instruction via conda
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6944: [DOCS] Improve windows build instruction via conda
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944#discussion_r527931922
##########
File path: docs/install/from_source.rst
##########
@@ -122,27 +122,56 @@ The configuration of TVM can be modified by `config.cmake`.
If everything goes well, we can go to :ref:`python-package-installation`
+.. _build-with-conda:
+
+Building with a Conda Environment
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Conda is a very handy way to the necessary obtain dependencies needed for running TVM.
+First, follow the `conda's installation guide <https://docs.conda.io/projects/conda/en/latest/user-guide/install/>`_
+to install miniconda or anaconda if you do not yet have conda in your system. Run the following command in a conda environment:
+
+.. code:: bash
+
+ conda env update -f conda/build-environment.yaml
+ conda activate tvm-build
+
Review comment:
1) It is better to create a new env with the yaml file you provide: https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-from-an-environment-yml-file
2) Document what these lines are doing for each line
3) Document conda/build-environment.yaml is under TVM's source tree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6944: [DOCS] Improve windows build instruction via conda
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6944:
URL: https://github.com/apache/incubator-tvm/pull/6944#issuecomment-731350126
cc @tmoreau89 @jroesch @junrushao1994 @rkimball @comaniac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org