[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #30921:
URL: https://github.com/apache/spark/pull/30921#discussion_r548751016



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##########
@@ -82,12 +82,12 @@ object OptimizeJsonExprs extends Rule[LogicalPlan] {
         child
 
       case g @ GetStructField(j @ JsonToStructs(schema: StructType, _, _, _), ordinal, _)
-          if schema.length > 1 =>
+          if schema.length > 1 && j.options.isEmpty =>

Review comment:
       Ur, you should not use `[TEST]` tag when you touch `src/main`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org