[jira] [Comment Edited] (CAMEL-11767) camel-catalog-maven - Maybe use shrinkwrap instead of gradle

["Grzegorz Grzybek (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-11767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643876#comment-17643876 ] 

Grzegorz Grzybek edited comment on CAMEL-11767 at 3/7/23 10:13 AM:
-------------------------------------------------------------------

In theory, {{org.apache.camel.catalog.maven.DefaultMavenArtifactProvider}} can be removed, because it's not used outside of one Syndesis integration test.

On the other hand, {{org.apache.camel.catalog.maven.MavenVersionManager}} and similar {{com.github.cameltooling.idea.service.CamelMavenVersionManager}} (and indirectly {{com.github.cameltooling.lsp.internal.CamelTextDocumentService()}} can be rewritten to not use Grape.

camel-catalog library can provide different resolver, which is used already in dsl/camel-camelet-main ({{org.apache.camel.main.download.MavenDependencyDownloader}}).

Because dsl/camel-camelet-main depends on catalog/camel-catalog, which in turn uses (indirectly) camel-api, camel-util, we have lot of places to move {{org.apache.camel.main.download.MavenDependencyDownloader}} (and what's important, also {{org.apache.camel.main.injection.DIRegistry}}) to.


was (Author: gzres):
In theory, {{org.apache.camel.catalog.maven.DefaultMavenArtifactProvider}} can be removed, because it's not used outside of one Syndesis integration test.

On the other hand, {{org.apache.camel.catalog.maven.MavenVersionManager}} and similar {{com.github.cameltooling.idea.service.CamelMavenVersionManager}} (and indirectly {{com.github.cameltooling.lsp.internal.CamelTextDocumentService()}} can be rewritten to not use Grape.

camel-catalog library can provide different resolved, which is used already in dsl/camel-camelet-main ({{org.apache.camel.main.download.MavenDependencyDownloader}}).

Because dsl/camel-camelet-main depends on catalog/camel-catalog, which in turn uses (indirectly) camel-api, camel-util, we have lot of places to move {{org.apache.camel.main.download.MavenDependencyDownloader}} (and what's important, also {{org.apache.camel.main.injection.DIRegistry}}) to.

> camel-catalog-maven - Maybe use shrinkwrap instead of gradle
> ------------------------------------------------------------
>
>                 Key: CAMEL-11767
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11767
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-catalog, tooling
>            Reporter: Claus Ibsen
>            Assignee: Grzegorz Grzybek
>            Priority: Minor
>             Fix For: 3.x
>
>
> We can look at using shrinkwrap resolver which has a nice API for downloading Maven JARs. We just need that to be able to download the camel-catalog JAR of a given version
> https://github.com/shrinkwrap/resolver



--
This message was sent by Atlassian Jira
(v8.20.10#820010)