[jira] [Resolved] (ISIS-2209) Orphaned validation (when @Action is NOT mandatory) isn't working.

["Andi Huber (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ISIS-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andi Huber resolved ISIS-2209.
------------------------------
    Resolution: Resolved

introduces OrphanedSupportingMethodValidator to do the job

(might need some refinement, if this detects orphans too aggressive)

> Orphaned validation (when @Action is NOT mandatory) isn't working.
> ------------------------------------------------------------------
>
>                 Key: ISIS-2209
>                 URL: https://issues.apache.org/jira/browse/ISIS-2209
>             Project: Isis
>          Issue Type: Bug
>            Reporter: Daniel Keir Haywood
>            Assignee: Andi Huber
>            Priority: Major
>             Fix For: 2.0.0
>
>
> Andi, 10:11
> I think we have 2 scenarios as configured:
> 1. @Action is mandatory ... then we could allow disable/hide/... prefixes on actions (no need for the validator to discard these cases)
> 2. @Action is optional ... then we need to preserve the original behavior as you suggested
> Dan: 10:13
> Yes, agreed. 
> I have reinstated that code, though something else must have changed because I couldn't reproduce scenario (2) to trigger the "orphaned methods" validation error.
> But scenario (1) works fine.
> For our own apps, I intend to make @Action mandatory, as per isis.reflector.validator.explication-annotations.action=true
> Andi, 10:16
> ok, we gonna need to write test cases to check this then
> Dan, 10:16
> I'll add a ticket



--
This message was sent by Atlassian Jira
(v8.3.4#803005)