You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/27 15:26:04 UTC
[jira] [Created] (BOOKKEEPER-483) precommit tests only check
toplevel rat file, not the one for submodules.
Ivan Kelly created BOOKKEEPER-483:
-------------------------------------
Summary: precommit tests only check toplevel rat file, not the one for submodules.
Key: BOOKKEEPER-483
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
Project: Bookkeeper
Issue Type: Bug
Reporter: Ivan Kelly
Assignee: Ivan Kelly
Therefore, not all rat errors are detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-483) precommit tests only check
toplevel rat file, not the one for submodules.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-483:
----------------------------------
Attachment: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
> Key: BOOKKEEPER-483
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-483) precommit tests only check
toplevel rat file, not the one for submodules.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509038#comment-13509038 ]
Flavio Junqueira commented on BOOKKEEPER-483:
---------------------------------------------
The patch is quite simple and it looks good to me. I checked the output of QA and it looks right to me. I just need a quick question: should we see the execution of "copyRatFiles clean" in the console output of the build? I can see the ones of "copyRatFiles patch" but not the one for clean.
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
> Key: BOOKKEEPER-483
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-483) precommit tests only check
toplevel rat file, not the one for submodules.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509809#comment-13509809 ]
Ivan Kelly commented on BOOKKEEPER-483:
---------------------------------------
because when the RAT task runs for clean, this patch has not been applied, therefore it won't do the copy. Once this patch is in, you'll see it for both.
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
> Key: BOOKKEEPER-483
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-483) precommit tests only check
toplevel rat file, not the one for submodules.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504821#comment-13504821 ]
Hadoop QA commented on BOOKKEEPER-483:
--------------------------------------
Testing JIRA BOOKKEEPER-483
WARNING: Running test-patch on a dirty local svn workspace
Patch <a href="/jira/secure/attachment/12555013/0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch">/jira/secure/attachment/12555013/0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch</a> downloaded at Tue Nov 27 18:12:18 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
. {color:red}WARNING{color}: the current HEAD has 8 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
. {color:red}WARNING{color}: the current HEAD has 9 javac warning(s)
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
. {color:red}WARNING: the current HEAD has Findbugs warning(s), they should be addressed ASAP{color}
{color:green}+1 TESTS{color}
. Tests run: 389
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/43/
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
> Key: BOOKKEEPER-483
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-483) precommit tests only check
toplevel rat file, not the one for submodules.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509826#comment-13509826 ]
Flavio Junqueira commented on BOOKKEEPER-483:
---------------------------------------------
Perhaps I don't understand very well what's going on and my observation might be naive. I thought that with the pre-commit I was supposed to see it because it runs with the patch applied, but perhaps it still uses the unpatched scripts. Could you clarify just for my own understanding, please?
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
> Key: BOOKKEEPER-483
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (BOOKKEEPER-483) precommit tests only check
toplevel rat file, not the one for submodules.
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509038#comment-13509038 ]
Flavio Junqueira edited comment on BOOKKEEPER-483 at 12/3/12 9:10 PM:
----------------------------------------------------------------------
The patch is quite simple and it looks good to me. I checked the output of QA and it looks right to me. I just need a quick clarification: should we see the execution of "copyRatFiles clean" in the console output of the build? I can see the ones of "copyRatFiles patch" but not the one for clean.
was (Author: fpj):
The patch is quite simple and it looks good to me. I checked the output of QA and it looks right to me. I just need a quick question: should we see the execution of "copyRatFiles clean" in the console output of the build? I can see the ones of "copyRatFiles patch" but not the one for clean.
> precommit tests only check toplevel rat file, not the one for submodules.
> -------------------------------------------------------------------------
>
> Key: BOOKKEEPER-483
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-483
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.2.0
>
> Attachments: 0001-BOOKKEEPER-483-check-all-modules-for-rat-errors.patch
>
>
> Therefore, not all rat errors are detected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira