You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "AHeise (via GitHub)" <gi...@apache.org> on 2024/09/26 12:31:49 UTC
[PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]
AHeise opened a new pull request, #121:
URL: https://github.com/apache/flink-connector-kafka/pull/121
This commit deprecates all classes that are slated for removal in the kafka-4.0 release compatible with Flink 2.0. I also deprecated internal classes to make later removal easier. Some public classes will cease to be public API but are still internally used.
Also introduce KafkaPartitioner to replace FlinkKafkaPartitioner. Relocate FlinkKafkaPartitioner to KafkaSink package and turn it into a functional interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise merged PR #121:
URL: https://github.com/apache/flink-connector-kafka/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]
Posted by "fapaul (via GitHub)" <gi...@apache.org>.
fapaul commented on code in PR #121:
URL: https://github.com/apache/flink-connector-kafka/pull/121#discussion_r1778335632
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java:
##########
@@ -18,39 +18,15 @@
package org.apache.flink.streaming.connectors.kafka.partitioner;
import org.apache.flink.annotation.PublicEvolving;
-
-import java.io.Serializable;
+import org.apache.flink.connector.kafka.sink.KafkaPartitioner;
/**
* A {@link FlinkKafkaPartitioner} wraps logic on how to partition records across partitions of
* multiple Kafka topics.
+ *
+ * @deprecated Use {@link KafkaPartitioner} instead for {@link
+ * org.apache.flink.connector.kafka.sink.KafkaSink}.
*/
@PublicEvolving
-public abstract class FlinkKafkaPartitioner<T> implements Serializable {
-
- private static final long serialVersionUID = -9086719227828020494L;
Review Comment:
Let's keep the `serialVersionUID` to avoid any strange serialization issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise commented on code in PR #121:
URL: https://github.com/apache/flink-connector-kafka/pull/121#discussion_r1778785067
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java:
##########
@@ -18,39 +18,15 @@
package org.apache.flink.streaming.connectors.kafka.partitioner;
import org.apache.flink.annotation.PublicEvolving;
-
-import java.io.Serializable;
+import org.apache.flink.connector.kafka.sink.KafkaPartitioner;
/**
* A {@link FlinkKafkaPartitioner} wraps logic on how to partition records across partitions of
* multiple Kafka topics.
+ *
+ * @deprecated Use {@link KafkaPartitioner} instead for {@link
+ * org.apache.flink.connector.kafka.sink.KafkaSink}.
*/
@PublicEvolving
-public abstract class FlinkKafkaPartitioner<T> implements Serializable {
-
- private static final long serialVersionUID = -9086719227828020494L;
Review Comment:
Good point. Restored the field inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]
Posted by "AHeise (via GitHub)" <gi...@apache.org>.
AHeise commented on code in PR #121:
URL: https://github.com/apache/flink-connector-kafka/pull/121#discussion_r1778785067
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java:
##########
@@ -18,39 +18,15 @@
package org.apache.flink.streaming.connectors.kafka.partitioner;
import org.apache.flink.annotation.PublicEvolving;
-
-import java.io.Serializable;
+import org.apache.flink.connector.kafka.sink.KafkaPartitioner;
/**
* A {@link FlinkKafkaPartitioner} wraps logic on how to partition records across partitions of
* multiple Kafka topics.
+ *
+ * @deprecated Use {@link KafkaPartitioner} instead for {@link
+ * org.apache.flink.connector.kafka.sink.KafkaSink}.
*/
@PublicEvolving
-public abstract class FlinkKafkaPartitioner<T> implements Serializable {
-
- private static final long serialVersionUID = -9086719227828020494L;
Review Comment:
Good point. Restored the field and replaced the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org