Re: [PR] Update sbt-assembly to 2.3.1 [pekko]

["He-Pin (via GitHub)" <gi...@apache.org>]

He-Pin commented on code in PR #1528:
URL: https://github.com/apache/pekko/pull/1528#discussion_r1921748725


##########
build.sbt:
##########
@@ -361,7 +361,7 @@ lazy val protobufV3 = pekkoModule("protobuf-v3")
         .inProject),
     assembly / assemblyOption := (assembly / assemblyOption).value.withIncludeScala(false).withIncludeBin(true),
     autoScalaLibrary := false, // do not include scala dependency in pom
-    exportJars := true, // in dependent projects, use assembled and shaded jar
+    exportJars := false, // in dependent projects, use assembled and shaded jar

Review Comment:
   ```suggestion
       exportJars := false, // in dependent projects, use assembled and shaded jar
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org