You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/10 07:19:45 UTC

[GitHub] [cloudstack] borisstoyanov opened a new issue #6084: router service offering tags are not honored

borisstoyanov opened a new issue #6084:
URL: https://github.com/apache/cloudstack/issues/6084


   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and main branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   Router Deployment
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on main branch.
   -->
   
   ~~~
   4.16
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   Having both VMware and Xen clusters
   custom offering for router with host tag: xen 
   Have a XenServer/xcp-ng host tagged with tag: xen
   system.vm.default.hypervisor = XenServer
   router.service.offering = [uuid-of-custom-offering]
   
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   When a user has 2 types of hypervisors, and he wants to create VRs on one of the types (say Xen), he would create a host tag in the custom router offering and tag a xen host/cluster. Then they would change the system.vm.default.hypervisor to XenServer. 
   
   
   ##### Steps
   
   ~~~
   - set the configuration described
   - deploy a vmware template in a newly created network
   - observe the failure
   ~~~
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   
   ~~~
   deployment successful, router on xen
   ~~~
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   
   <!-- Paste verbatim command output between quotes below -->
   ~~~
   deployment fails, cloudstack tried to deploy an ova to xen
   ~~~
   [vmware.log](https://github.com/apache/cloudstack/files/8221143/vmware.log)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache edited a comment on issue #6084: router service offering tags are not honored

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #6084:
URL: https://github.com/apache/cloudstack/issues/6084#issuecomment-1068906656


   the current logic to start VRs is (since many years ago)
   (1) find destination of user vm
   (2) create VRs in the same cluster as user vm (so same hypervisor)
   (3) start VRs
   
   in step 2, the hypervisor type of VRs is set to the hypervisor of user vm (vmware in the example), therefore in stpe 3 it cannot be deployed in hosts with other hypervisors (e.g. in a xenserver cluster).
   
   in my opinion, the results in the description is expected, this is not a bug. the offering tags are not considered in step 2, but tags are considered in step 3 which caused the failure deployment.
   
   I would regard it as a feature request (the requirement needs to be discussed)
   @nvazquez @borisstoyanov 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez edited a comment on issue #6084: router service offering tags are not honored

Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #6084:
URL: https://github.com/apache/cloudstack/issues/6084#issuecomment-1070330116


   I think it is a limitation on the setting 'system.vm.default.hypervisor'. Since we have the option to let the administrators decide which hypervisor to use for system VMs then the current logic to start VRs could be adapted as well. IMO the step 1 could be extended to consider the value of this setting when finding a destination for the user VM (destination host hypervisor should be the same as the one in the setting). What do you think @weizhouapache @borisstoyanov ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #6084: router service offering tags are not honored

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #6084:
URL: https://github.com/apache/cloudstack/issues/6084#issuecomment-1068906656


   the current logic to start VRs is
   (1) find destination of user vm
   (2) create VRs in the same cluster as user vm (so same hypervisor)
   (3) start VRs
   
   in step 2, the hypervisor type of VRs is set to the hypervisor of user vm (vmware in the example), therefore in stpe 3 it cannot be deployed in hosts with other hypervisors (e.g. in a xenserver cluster).
   
   in my opinion, the results in the description is expected, this is not a bug. the offering tags are not considered in step 2, but tags are considered in step 3 which caused the failure deployment.
   
   I would regard it as a feature request (the requirement needs to be discussed)
   @nvazquez @borisstoyanov 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez edited a comment on issue #6084: router service offering tags are not honored

Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #6084:
URL: https://github.com/apache/cloudstack/issues/6084#issuecomment-1070330116


   I think it is a limitation on the setting 'system.vm.default.hypervisor'. Since we have the option to let the administrators decide which hypervisor to use for system VMs then the current logic to start VRs could be adapted as well. IMO the step 1 could be extended to consider the value of this setting when finding a destination for the user VM. What do you think @weizhouapache @borisstoyanov ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on issue #6084: router service offering tags are not honored

Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #6084:
URL: https://github.com/apache/cloudstack/issues/6084#issuecomment-1070330116


   I think it is a limitation on the use of the setting 'system.vm.default.hypervisor'. Since we have the option to let the administrators decide which hypervisor to use for system VMs then the current logic to start VRs could be adapted as well. IMO the step 1 could be extended to consider the value of this setting when finding a destination for the user VM. What do you think @weizhouapache @borisstoyanov ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #6084: router service offering tags are not honored

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #6084:
URL: https://github.com/apache/cloudstack/issues/6084#issuecomment-1075028877


   According to our discussion, this issue should has been fixed by #1839, but reverted by #4304
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org