You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "brandboat (via GitHub)" <gi...@apache.org> on 2024/06/17 17:11:17 UTC

[PR] KAFKA-16975 The error message of creating `__cluster_metadata` should NOT be "Authorization failed" [kafka]

brandboat opened a new pull request, #16372:
URL: https://github.com/apache/kafka/pull/16372

   related to https://issues.apache.org/jira/browse/KAFKA-16975
   The error message of creating "__cluster_metadata" by admin is "Authorization failed.". That could confuse users that it implies you "can" create it in using root. While creating this topic is prohibited. This pr corrected the error code and error message in KafkaApis when user creating __cluster_metadata topic.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16975 The error message of creating `__cluster_metadata` should NOT be "Authorization failed" [kafka]

Posted by "brandboat (via GitHub)" <gi...@apache.org>.
brandboat commented on PR #16372:
URL: https://github.com/apache/kafka/pull/16372#issuecomment-2225376910

   > @brandboat This PR returns the error code with obvious message, so it seems we don't need to log it. Hence, could you please remove following log?
   
   Make sense to me, I removed those logs in the latest commit. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16975 The error message of creating `__cluster_metadata` should NOT be "Authorization failed" [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #16372:
URL: https://github.com/apache/kafka/pull/16372#issuecomment-2232414276

   @brandboat Could you please rebase code to trigger QA again? Those failed tests pass on my local, but I'd like to run them again on our QA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16975 The error message of creating `__cluster_metadata` should NOT be "Authorization failed" [kafka]

Posted by "brandboat (via GitHub)" <gi...@apache.org>.
brandboat commented on PR #16372:
URL: https://github.com/apache/kafka/pull/16372#issuecomment-2211165843

   > @brandboat take a look at this PR https://github.com/apache/kafka/pull/12885 and make sure that you also remove any code that I added to return authorization errors when creating the __cluster_metadata topic. This PR returns an invalid request error but leaves being code that is not needed anymore.
   
   Thank you. I've checked the PR you mentioned and didn't find any unused items left behind, perhaps I overlooked something...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16975 The error message of creating `__cluster_metadata` should NOT be "Authorization failed" [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16372:
URL: https://github.com/apache/kafka/pull/16372


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-16975 The error message of creating `__cluster_metadata` should NOT be "Authorization failed" [kafka]

Posted by "jsancio (via GitHub)" <gi...@apache.org>.
jsancio commented on PR #16372:
URL: https://github.com/apache/kafka/pull/16372#issuecomment-2209492106

   > @jsancio Could you please take a look? not sure why #12885 decided to return Authorization error instead of bad request. Please feel free to correct me. thanks
   
   I don't have a strong argument for returning an authorization error vs an invalid request error as long as the UX makes sense to the user.
   
   @brandboat take a look at this PR https://github.com/apache/kafka/pull/12885 and make sure that you also remove any code that I added to return authorization errors when creating the __cluster_metadata topic. This PR returns an invalid request error but leaves being code that is not needed anymore.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org